Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialMovePage.php

Summary

Maintainability
F
1 wk
Test Coverage

File SpecialMovePage.php has 848 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Major
Found in includes/specials/SpecialMovePage.php - About 2 days to fix

    Method showForm has 381 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function showForm( $err, $isPermError = false ) {
        $this->getSkin()->setRelevantTitle( $this->oldTitle );

        $out = $this->getOutput();
        $out->setPageTitleMsg( $this->msg( 'move-page' )->plaintextParams( $this->oldTitle->getPrefixedText() ) );
    Severity: Major
    Found in includes/specials/SpecialMovePage.php - About 1 day to fix

      Function doSubmit has a Cognitive Complexity of 77 (exceeds 5 allowed). Consider refactoring.
      Open

          private function doSubmit() {
        $user = $this->getUser();

        if ( $user->pingLimiter( 'move' ) ) {
            throw new ThrottledError;
      Severity: Minor
      Found in includes/specials/SpecialMovePage.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function showForm has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function showForm( $err, $isPermError = false ) {
        $this->getSkin()->setRelevantTitle( $this->oldTitle );

        $out = $this->getOutput();
        $out->setPageTitleMsg( $this->msg( 'move-page' )->plaintextParams( $this->oldTitle->getPrefixedText() ) );
      Severity: Minor
      Found in includes/specials/SpecialMovePage.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method doSubmit has 228 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function doSubmit() {
        $user = $this->getUser();

        if ( $user->pingLimiter( 'move' ) ) {
            throw new ThrottledError;
      Severity: Major
      Found in includes/specials/SpecialMovePage.php - About 1 day to fix

        Method execute has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function execute( $par ) {
        $this->useTransactionalTimeLimit();
        $this->checkReadOnly();
        $this->setHeaders();
        $this->outputHeader();
        Severity: Major
        Found in includes/specials/SpecialMovePage.php - About 2 hrs to fix

          Method __construct has 13 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  MovePageFactory $movePageFactory,
        PermissionManager $permManager,
        UserOptionsLookup $userOptionsLookup,
        IConnectionProvider $dbProvider,
        IContentHandlerFactory $contentHandlerFactory,
          Severity: Major
          Found in includes/specials/SpecialMovePage.php - About 1 hr to fix

            Function execute has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                public function execute( $par ) {
        $this->useTransactionalTimeLimit();
        $this->checkReadOnly();
        $this->setHeaders();
        $this->outputHeader();
            Severity: Minor
            Found in includes/specials/SpecialMovePage.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method showSubpagesList has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                private function showSubpagesList( $subpages, $pagecount, $msg, $truncatedMsg, $noSubpageMsg = false ) {
            Severity: Minor
            Found in includes/specials/SpecialMovePage.php - About 35 mins to fix

              Avoid too many return statements within this method.
              Open

                              return;
              Severity: Major
              Found in includes/specials/SpecialMovePage.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return;
                Severity: Major
                Found in includes/specials/SpecialMovePage.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return;
                  Severity: Major
                  Found in includes/specials/SpecialMovePage.php - About 30 mins to fix

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                        public function __construct(
        MovePageFactory $movePageFactory,
        PermissionManager $permManager,
        UserOptionsLookup $userOptionsLookup,
        IConnectionProvider $dbProvider,
                    Severity: Major
                    Found in includes/specials/SpecialMovePage.php and 3 other locations - About 35 mins to fix
                    includes/Revision/RevisionStoreFactory.php on lines 106..134
                    includes/language/MessageCache.php on lines 215..253
                    includes/page/RollbackPage.php on lines 133..163

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 92.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status