Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialPageLanguage.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method changePageLanguage has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function changePageLanguage( IContextSource $context, Title $title,
        $newLanguage, $reason = "", array $tags = [], IDatabase $dbw = null ) {
        // Get the default language for the wiki
        $defLang = $context->getConfig()->get( MainConfigNames::LanguageCode );
Severity: Major
Found in includes/specials/SpecialPageLanguage.php - About 2 hrs to fix

    Method getFormFields has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getFormFields() {
        // Get default from the subpage of Special page
        $defaultName = $this->par;
        $title = $defaultName ? Title::newFromText( $defaultName ) : null;
        if ( $title ) {
    Severity: Minor
    Found in includes/specials/SpecialPageLanguage.php - About 1 hr to fix

      Method onSubmit has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function onSubmit( array $data ) {
        $pageName = $data['pagename'];

        // Check if user wants to use default language
        if ( $data['selectoptions'] == 1 ) {
      Severity: Minor
      Found in includes/specials/SpecialPageLanguage.php - About 1 hr to fix

        Method changePageLanguage has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static function changePageLanguage( IContextSource $context, Title $title,
        $newLanguage, $reason = "", array $tags = [], IDatabase $dbw = null ) {
        Severity: Minor
        Found in includes/specials/SpecialPageLanguage.php - About 45 mins to fix

          Avoid too many return statements within this method.
          Open

                  return Status::newGood( (object)[
            'oldLanguage' => $logOld,
            'newLanguage' => $logNew,
            'logId' => $logid,
        ] );
          Severity: Major
          Found in includes/specials/SpecialPageLanguage.php - About 30 mins to fix

            Function changePageLanguage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function changePageLanguage( IContextSource $context, Title $title,
        $newLanguage, $reason = "", array $tags = [], IDatabase $dbw = null ) {
        // Get the default language for the wiki
        $defLang = $context->getConfig()->get( MainConfigNames::LanguageCode );
            Severity: Minor
            Found in includes/specials/SpecialPageLanguage.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status