Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialRecentChangesLinked.php

Summary

Maintainability
D
2 days
Test Coverage

Function doMainQuery has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
Open

    protected function doMainQuery( $tables, $select, $conds, $query_options,
        $join_conds, FormOptions $opts
    ) {
        $target = $opts['target'];
        $showlinkedto = $opts['showlinkedto'];
Severity: Minor
Found in includes/specials/SpecialRecentChangesLinked.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doMainQuery has 167 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function doMainQuery( $tables, $select, $conds, $query_options,
        $join_conds, FormOptions $opts
    ) {
        $target = $opts['target'];
        $showlinkedto = $opts['showlinkedto'];
Severity: Major
Found in includes/specials/SpecialRecentChangesLinked.php - About 6 hrs to fix

    File SpecialRecentChangesLinked.php has 277 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/specials/SpecialRecentChangesLinked.php - About 2 hrs to fix

      Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              WatchedItemStoreInterface $watchedItemStore,
        MessageCache $messageCache,
        UserOptionsLookup $userOptionsLookup,
        SearchEngineFactory $searchEngineFactory,
        ChangeTagsStore $changeTagsStore,
      Severity: Major
      Found in includes/specials/SpecialRecentChangesLinked.php - About 50 mins to fix

        Method doMainQuery has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            protected function doMainQuery( $tables, $select, $conds, $query_options,
        $join_conds, FormOptions $opts
        Severity: Minor
        Found in includes/specials/SpecialRecentChangesLinked.php - About 45 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false; // should never happen
          Severity: Major
          Found in includes/specials/SpecialRecentChangesLinked.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $subsql[0]
                ->setMaxExecutionTime( $this->getConfig()->get( MainConfigNames::MaxExecutionTimeForExpensiveQueries ) )
                ->caller( __METHOD__ )->fetchResultSet();
            Severity: Major
            Found in includes/specials/SpecialRecentChangesLinked.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $dbr->newSelectQueryBuilder()
                ->select( '*' )
                ->from(
                    new Subquery( $unionQueryBuilder->getSQL() ),
                    'main'
              Severity: Major
              Found in includes/specials/SpecialRecentChangesLinked.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status