Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialRevisionDelete.php

Summary

Maintainability
F
3 days
Test Coverage

File SpecialRevisionDelete.php has 539 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Implements Special:Revisiondelete
 *
 * This program is free software; you can redistribute it and/or modify
Severity: Major
Found in includes/specials/SpecialRevisionDelete.php - About 1 day to fix

    Method execute has 116 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute( $par ) {
        $this->useTransactionalTimeLimit();

        $this->checkPermissions();
        $this->checkReadOnly();
    Severity: Major
    Found in includes/specials/SpecialRevisionDelete.php - About 4 hrs to fix

      Method showForm has 108 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function showForm() {
        $userAllowed = true;

        // Messages: revdelete-selected-text, revdelete-selected-file, logdelete-selected
        $out = $this->getOutput();
      Severity: Major
      Found in includes/specials/SpecialRevisionDelete.php - About 4 hrs to fix

        Function showForm has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function showForm() {
        $userAllowed = true;

        // Messages: revdelete-selected-text, revdelete-selected-file, logdelete-selected
        $out = $this->getOutput();
        Severity: Minor
        Found in includes/specials/SpecialRevisionDelete.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function execute has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function execute( $par ) {
        $this->useTransactionalTimeLimit();

        $this->checkPermissions();
        $this->checkReadOnly();
        Severity: Minor
        Found in includes/specials/SpecialRevisionDelete.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method tryShowFile has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function tryShowFile( $archiveName ) {
        $repo = $this->repoGroup->getLocalRepo();
        $oimage = $repo->newFromArchiveName( $this->targetObj, $archiveName );
        $oimage->load();
        // Check if user is allowed to see this file
        Severity: Minor
        Found in includes/specials/SpecialRevisionDelete.php - About 1 hr to fix

          Method buildCheckBoxes has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function buildCheckBoxes() {
        $fields = [];

        $type = 'radio';
          Severity: Minor
          Found in includes/specials/SpecialRevisionDelete.php - About 1 hr to fix

            Method showConvenienceLinks has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function showConvenienceLinks() {
        $linkRenderer = $this->getLinkRenderer();
        # Give a link to the logs/hist for this page
        if ( $this->targetObj ) {
            // Also set header tabs to be for the target.
            Severity: Minor
            Found in includes/specials/SpecialRevisionDelete.php - About 1 hr to fix

              Method submit has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function submit() {
        # Check edit token on submission
        $token = $this->getRequest()->getVal( 'wpEditToken' );
        if ( $this->submitClicked && !$this->getUser()->matchEditToken( $token ) ) {
            $this->getOutput()->addWikiMsg( 'sessionfailure' );
              Severity: Minor
              Found in includes/specials/SpecialRevisionDelete.php - About 1 hr to fix

                Function buildCheckBoxes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function buildCheckBoxes() {
        $fields = [];

        $type = 'radio';
                Severity: Minor
                Found in includes/specials/SpecialRevisionDelete.php - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function submit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function submit() {
        # Check edit token on submission
        $token = $this->getRequest()->getVal( 'wpEditToken' );
        if ( $this->submitClicked && !$this->getUser()->matchEditToken( $token ) ) {
            $this->getOutput()->addWikiMsg( 'sessionfailure' );
                Severity: Minor
                Found in includes/specials/SpecialRevisionDelete.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function showConvenienceLinks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function showConvenienceLinks() {
        $linkRenderer = $this->getLinkRenderer();
        # Give a link to the logs/hist for this page
        if ( $this->targetObj ) {
            // Also set header tabs to be for the target.
                Severity: Minor
                Found in includes/specials/SpecialRevisionDelete.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function tryShowFile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function tryShowFile( $archiveName ) {
        $repo = $this->repoGroup->getLocalRepo();
        $oimage = $repo->newFromArchiveName( $this->targetObj, $archiveName );
        $oimage->load();
        // Check if user is allowed to see this file
                Severity: Minor
                Found in includes/specials/SpecialRevisionDelete.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( $this->permissionManager->userHasRight( $user, 'suppressionlog' ) ) {
            $suppressLogPage = new LogPage( 'suppress' );
            $output->addHTML( "<h2>" . $suppressLogPage->getName()->escaped() . "</h2>\n" );
            LogEventsList::showLogExtract(
                $output,
                Severity: Minor
                Found in includes/specials/SpecialRevisionDelete.php and 1 other location - About 55 mins to fix
                includes/specials/SpecialRevisionDelete.php on lines 266..277

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if ( $this->permissionManager->userHasRight( $user, 'deletedhistory' ) ) {
            # Show relevant lines from the deletion log
            $deleteLogPage = new LogPage( 'delete' );
            $output->addHTML( "<h2>" . $deleteLogPage->getName()->escaped() . "</h2>\n" );
            LogEventsList::showLogExtract(
                Severity: Minor
                Found in includes/specials/SpecialRevisionDelete.php and 1 other location - About 55 mins to fix
                includes/specials/SpecialRevisionDelete.php on lines 279..289

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status