Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialStatistics.php

Summary

Maintainability
C
1 day
Test Coverage

Function getOtherStats has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    private function getOtherStats( array $stats ) {
        $return = '';

        foreach ( $stats as $header => $items ) {
            // Identify the structure used
Severity: Minor
Found in includes/specials/SpecialStatistics.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getGroupStats has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getGroupStats() {
        $linkRenderer = $this->getLinkRenderer();
        $lang = $this->getLanguage();
        $text = '';
        foreach ( $this->userGroupManager->listAllGroups() as $group ) {
Severity: Minor
Found in includes/specials/SpecialStatistics.php - About 1 hr to fix

    Method execute has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute( $par ) {
        $this->setHeaders();
        $this->outputHeader();
        $this->getOutput()->addModuleStyles( 'mediawiki.special' );
    Severity: Minor
    Found in includes/specials/SpecialStatistics.php - About 1 hr to fix

      Method getPageStats has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function getPageStats() {
        $linkRenderer = $this->getLinkRenderer();

        $specialAllPagesTitle = SpecialPage::getTitleFor( 'Allpages' );
        $pageStatsHtml = Html::rawElement( 'tr', [],
      Severity: Minor
      Found in includes/specials/SpecialStatistics.php - About 1 hr to fix

        Method getOtherStats has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function getOtherStats( array $stats ) {
        $return = '';

        foreach ( $stats as $header => $items ) {
            // Identify the structure used
        Severity: Minor
        Found in includes/specials/SpecialStatistics.php - About 1 hr to fix

          Method formatRow has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private function formatRow( $text, $number, $trExtraParams = [],
        $descMsg = '', $descMsgParam = ''
          Severity: Minor
          Found in includes/specials/SpecialStatistics.php - About 35 mins to fix

            Function getGroupStats has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getGroupStats() {
        $linkRenderer = $this->getLinkRenderer();
        $lang = $this->getLanguage();
        $text = '';
        foreach ( $this->userGroupManager->listAllGroups() as $group ) {
            Severity: Minor
            Found in includes/specials/SpecialStatistics.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status