Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/SpecialUploadStash.php

Summary

Maintainability
C
1 day
Test Coverage

File SpecialUploadStash.php has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/specials/SpecialUploadStash.php - About 2 hrs to fix

    Method showUploads has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function showUploads() {
        // sets the title, etc.
        $this->setHeaders();
        $this->outputHeader();
    Severity: Minor
    Found in includes/specials/SpecialUploadStash.php - About 1 hr to fix

      Method outputRemoteScaledThumb has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function outputRemoteScaledThumb( $file, $params ) {
        // We need to use generateThumbName() instead of thumbName(), because
        // the suffix needs to match the file name for the remote thumbnailer
        // to work
        $scalerThumbName = $file->generateThumbName( $file->getName(), $params );
      Severity: Minor
      Found in includes/specials/SpecialUploadStash.php - About 1 hr to fix

        Function parseKey has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            private function parseKey( $key ) {
        $type = strtok( $key, '/' );

        if ( $type !== 'file' && $type !== 'thumb' ) {
            throw new UploadStashBadPathException(
        Severity: Minor
        Found in includes/specials/SpecialUploadStash.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parseKey has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function parseKey( $key ) {
        $type = strtok( $key, '/' );

        if ( $type !== 'file' && $type !== 'thumb' ) {
            throw new UploadStashBadPathException(
        Severity: Minor
        Found in includes/specials/SpecialUploadStash.php - About 1 hr to fix

          Function outputRemoteScaledThumb has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              private function outputRemoteScaledThumb( $file, $params ) {
        // We need to use generateThumbName() instead of thumbName(), because
        // the suffix needs to match the file name for the remote thumbnailer
        // to work
        $scalerThumbName = $file->generateThumbName( $file->getName(), $params );
          Severity: Minor
          Found in includes/specials/SpecialUploadStash.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status