Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/forms/PreferencesFormOOUI.php

Summary

Maintainability
C
1 day
Test Coverage

File PreferencesFormOOUI.php has 268 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/specials/forms/PreferencesFormOOUI.php - About 2 hrs to fix

    Method createDesktopPreferencesForm has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function createDesktopPreferencesForm() {
        $tabPanels = [];
        foreach ( $this->mFieldTree as $key => $val ) {
            if ( !is_array( $val ) ) {
                wfDebug( __METHOD__ . " encountered a field not attached to a section: '$key'" );
    Severity: Minor
    Found in includes/specials/forms/PreferencesFormOOUI.php - About 1 hr to fix

      Method createMobilePreferencesForm has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function createMobilePreferencesForm() {
        $sectionButtons = [];
        $sectionContents = [];
        $iconNames = $this->getIconNames();
      Severity: Minor
      Found in includes/specials/forms/PreferencesFormOOUI.php - About 1 hr to fix

        Method createContentMobile has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function createContentMobile( $key, $label, $content ) {
        $contentDiv = ( new OOUI\Tag( 'div' ) );
        $contentDiv->addClasses( [
            'mw-prefs-content-page',
            'mw-prefs-section-fieldset',
        Severity: Minor
        Found in includes/specials/forms/PreferencesFormOOUI.php - About 1 hr to fix

          Function addFields has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function addFields( $descriptor ) {
        // Replace checkbox fields with toggle switchs on Special:Preferences
        if ( $this->isMobileLayout() && $this->getTitle()->isSpecial( 'Preferences' ) ) {
            foreach ( $descriptor as $_ => &$info ) {
                if ( isset( $info['type'] ) && in_array( $info['type'], [ 'check', 'toggle' ] ) ) {
          Severity: Minor
          Found in includes/specials/forms/PreferencesFormOOUI.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function filterDataForSubmit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function filterDataForSubmit( $data ) {
        foreach ( $this->mFlatFields as $fieldname => $field ) {
            if ( $field instanceof HTMLNestedFilterable ) {
                $info = $field->mParams;
                $prefix = $info['prefix'] ?? $fieldname;
          Severity: Minor
          Found in includes/specials/forms/PreferencesFormOOUI.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status