Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/forms/UploadForm.php

Summary

Maintainability
D
2 days
Test Coverage

File UploadForm.php has 367 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/specials/forms/UploadForm.php - About 4 hrs to fix

    Method getDescriptionSection has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getDescriptionSection() {
        $config = $this->getConfig();
        if ( $this->mSessionKey ) {
            $stash = $this->localRepo->getUploadStash( $this->getUser() );
            try {
    Severity: Major
    Found in includes/specials/forms/UploadForm.php - About 3 hrs to fix

      Method getSourceSection has 72 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getSourceSection() {
        if ( $this->mSessionKey ) {
            return [
                'SessionKey' => [
                    'type' => 'hidden',
      Severity: Major
      Found in includes/specials/forms/UploadForm.php - About 2 hrs to fix

        Method __construct has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __construct(
        array $options = [],
        IContextSource $context = null,
        LinkRenderer $linkRenderer = null,
        LocalRepo $localRepo = null,
        Severity: Major
        Found in includes/specials/forms/UploadForm.php - About 2 hrs to fix

          Function getDescriptionSection has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function getDescriptionSection() {
        $config = $this->getConfig();
        if ( $this->mSessionKey ) {
            $stash = $this->localRepo->getUploadStash( $this->getUser() );
            try {
          Severity: Minor
          Found in includes/specials/forms/UploadForm.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getExtensionsMessage has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function getExtensionsMessage() {
        # Print a list of allowed file extensions, if so configured.  We ignore
        # MIME type here, it's incomprehensible to most people and too long.
        $config = $this->getConfig();
          Severity: Minor
          Found in includes/specials/forms/UploadForm.php - About 1 hr to fix

            Method getOptionsSection has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function getOptionsSection() {
        $user = $this->getUser();
        if ( $user->isRegistered() ) {
            $descriptor = [
                'Watchthis' => [
            Severity: Minor
            Found in includes/specials/forms/UploadForm.php - About 1 hr to fix

              Function __construct has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function __construct(
        array $options = [],
        IContextSource $context = null,
        LinkRenderer $linkRenderer = null,
        LocalRepo $localRepo = null,
              Severity: Minor
              Found in includes/specials/forms/UploadForm.php - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method __construct has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      array $options = [],
        IContextSource $context = null,
        LinkRenderer $linkRenderer = null,
        LocalRepo $localRepo = null,
        Language $contentLanguage = null,
              Severity: Major
              Found in includes/specials/forms/UploadForm.php - About 50 mins to fix

                There are no issues that match your filters.

                Category
                Status