Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/helpers/ImportReporter.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method reportPage has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function reportPage( ?PageIdentity $pageIdentity, $foreignTitle, $revisionCount,
            $successCount, $pageInfo ) {
        call_user_func_array( $this->mOriginalPageOutCallback, func_get_args() );

        if ( $pageIdentity === null ) {
Severity: Major
Found in includes/specials/helpers/ImportReporter.php - About 2 hrs to fix

    Function reportPage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function reportPage( ?PageIdentity $pageIdentity, $foreignTitle, $revisionCount,
            $successCount, $pageInfo ) {
        call_user_func_array( $this->mOriginalPageOutCallback, func_get_args() );

        if ( $pageIdentity === null ) {
    Severity: Minor
    Found in includes/specials/helpers/ImportReporter.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method reportPage has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function reportPage( ?PageIdentity $pageIdentity, $foreignTitle, $revisionCount,
            $successCount, $pageInfo ) {
    Severity: Minor
    Found in includes/specials/helpers/ImportReporter.php - About 35 mins to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct( $importer, $upload, $interwiki, $reason = "", IContextSource $context = null ) {
      Severity: Minor
      Found in includes/specials/helpers/ImportReporter.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status