Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/pagers/ActiveUsersPager.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method getQueryInfo has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getQueryInfo( $data = null ) {
        $dbr = $this->getDatabase();

        $activeUserSeconds = $this->getConfig()->get( MainConfigNames::ActiveUserDays ) * 86400;
        $timestamp = $dbr->timestamp( (int)wfTimestamp( TS_UNIX ) - $activeUserSeconds );
Severity: Major
Found in includes/specials/pagers/ActiveUsersPager.php - About 2 hrs to fix

    Method formatRow has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function formatRow( $row ) {
        $userName = $row->user_name;

        $ulinks = Linker::userLink( $row->user_id, $userName );
        $ulinks .= Linker::userToolLinks(
    Severity: Minor
    Found in includes/specials/pagers/ActiveUsersPager.php - About 1 hr to fix

      Method __construct has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct(
        IContextSource $context,
        HookContainer $hookContainer,
        LinkBatchFactory $linkBatchFactory,
        IConnectionProvider $dbProvider,
      Severity: Minor
      Found in includes/specials/pagers/ActiveUsersPager.php - About 1 hr to fix

        Method buildQueryInfo has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function buildQueryInfo( $offset, $limit, $order ) {
        $fname = __METHOD__ . ' (' . $this->getSqlComment() . ')';

        $sortColumns = array_merge( [ $this->mIndexField ], $this->mExtraSortFields );
        if ( $order === self::QUERY_ASCENDING ) {
        Severity: Minor
        Found in includes/specials/pagers/ActiveUsersPager.php - About 1 hr to fix

          Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  IContextSource $context,
        HookContainer $hookContainer,
        LinkBatchFactory $linkBatchFactory,
        IConnectionProvider $dbProvider,
        UserGroupManager $userGroupManager,
          Severity: Major
          Found in includes/specials/pagers/ActiveUsersPager.php - About 1 hr to fix

            Function formatRow has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function formatRow( $row ) {
        $userName = $row->user_name;

        $ulinks = Linker::userLink( $row->user_id, $userName );
        $ulinks .= Linker::userToolLinks(
            Severity: Minor
            Found in includes/specials/pagers/ActiveUsersPager.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status