Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/specials/pagers/ProtectedPagesPager.php

Summary

Maintainability
D
2 days
Test Coverage

Method formatValue has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function formatValue( $field, $value ) {
        /** @var stdClass $row */
        $row = $this->mCurrentRow;
        $linkRenderer = $this->getLinkRenderer();
Severity: Major
Found in includes/specials/pagers/ProtectedPagesPager.php - About 4 hrs to fix

    Function formatValue has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        public function formatValue( $field, $value ) {
        /** @var stdClass $row */
        $row = $this->mCurrentRow;
        $linkRenderer = $this->getLinkRenderer();
    Severity: Minor
    Found in includes/specials/pagers/ProtectedPagesPager.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File ProtectedPagesPager.php has 312 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
    Severity: Minor
    Found in includes/specials/pagers/ProtectedPagesPager.php - About 3 hrs to fix

      Method getQueryInfo has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getQueryInfo() {
        $dbr = $this->getDatabase();
        $conds = $this->mConds;
        $conds[] = $dbr->expr( 'pr_expiry', '>', $dbr->timestamp() )
            ->or( 'pr_expiry', '=', null );
      Severity: Major
      Found in includes/specials/pagers/ProtectedPagesPager.php - About 2 hrs to fix

        Method __construct has 16 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                IContextSource $context,
        CommentStore $commentStore,
        LinkBatchFactory $linkBatchFactory,
        LinkRenderer $linkRenderer,
        IConnectionProvider $dbProvider,
        Severity: Major
        Found in includes/specials/pagers/ProtectedPagesPager.php - About 2 hrs to fix

          Function preprocessResults has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              public function preprocessResults( $result ) {
        # Do a link batch query
        $lb = $this->linkBatchFactory->newLinkBatch();
        $userids = [];
        $rowsWithComments = [];
          Severity: Minor
          Found in includes/specials/pagers/ProtectedPagesPager.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method preprocessResults has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function preprocessResults( $result ) {
        # Do a link batch query
        $lb = $this->linkBatchFactory->newLinkBatch();
        $userids = [];
        $rowsWithComments = [];
          Severity: Minor
          Found in includes/specials/pagers/ProtectedPagesPager.php - About 1 hr to fix

            Function getQueryInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getQueryInfo() {
        $dbr = $this->getDatabase();
        $conds = $this->mConds;
        $conds[] = $dbr->expr( 'pr_expiry', '>', $dbr->timestamp() )
            ->or( 'pr_expiry', '=', null );
            Severity: Minor
            Found in includes/specials/pagers/ProtectedPagesPager.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status