Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/upload/UploadFromUrl.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method reallyFetchFile has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function reallyFetchFile( $httpOptions = [] ) {
        $copyUploadProxy = MediaWikiServices::getInstance()->getMainConfig()->get( MainConfigNames::CopyUploadProxy );
        $copyUploadTimeout = MediaWikiServices::getInstance()->getMainConfig()
            ->get( MainConfigNames::CopyUploadTimeout );
        if ( $this->mTempPath === false ) {
Severity: Major
Found in includes/upload/UploadFromUrl.php - About 2 hrs to fix

    Function isAllowedHost has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function isAllowedHost( $url ) {
        $domains = self::getAllowedHosts();
        if ( !count( $domains ) ) {
            return true;
        }
    Severity: Minor
    Found in includes/upload/UploadFromUrl.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function reallyFetchFile has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function reallyFetchFile( $httpOptions = [] ) {
        $copyUploadProxy = MediaWikiServices::getInstance()->getMainConfig()->get( MainConfigNames::CopyUploadProxy );
        $copyUploadTimeout = MediaWikiServices::getInstance()->getMainConfig()
            ->get( MainConfigNames::CopyUploadTimeout );
        if ( $this->mTempPath === false ) {
    Severity: Minor
    Found in includes/upload/UploadFromUrl.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $status;
    Severity: Major
    Found in includes/upload/UploadFromUrl.php - About 30 mins to fix

      Function getAllowedHosts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function getAllowedHosts(): array {
        $config = MediaWikiServices::getInstance()->getMainConfig();
        $domains = $config->get( MainConfigNames::CopyUploadsDomains );

        if ( $config->get( MainConfigNames::CopyUploadAllowOnWikiDomainConfig ) ) {
      Severity: Minor
      Found in includes/upload/UploadFromUrl.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status