Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/user/ActorStore.php

Summary

Maintainability
D
1 day
Test Coverage

File ActorStore.php has 409 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in includes/user/ActorStore.php - About 5 hrs to fix

    ActorStore has 25 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ActorStore implements UserIdentityLookup, ActorNormalization {

    public const UNKNOWN_USER_NAME = 'Unknown user';

    private const LOCAL_CACHE_SIZE = 100;
    Severity: Minor
    Found in includes/user/ActorStore.php - About 2 hrs to fix

      Method acquireSystemActorId has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function acquireSystemActorId( UserIdentity $user, IDatabase $dbw ): int {
        $this->checkDatabaseDomain( $dbw );
        [ $userId, $userName ] = $this->validateActorForInsertion( $user );

        $existingActorId = $this->findActorIdInternal( $userName, $dbw );
      Severity: Minor
      Found in includes/user/ActorStore.php - About 1 hr to fix

        Method newActorFromRowFields has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function newActorFromRowFields( $userId, $name, $actorId ): UserIdentity {
        // For backwards compatibility we are quite relaxed about what to accept,
        // but try not to create entirely incorrect objects. As we move more code
        // from ActorMigration aliases to proper join with the actor table,
        // we should use ::newActorFromRow more, and eventually deprecate this method.
        Severity: Minor
        Found in includes/user/ActorStore.php - About 1 hr to fix

          Method acquireActorId has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function acquireActorId( UserIdentity $user, IDatabase $dbw ): int {
        $this->checkDatabaseDomain( $dbw );
        [ $userId, $userName ] = $this->validateActorForInsertion( $user );

        // allow cache to be used, because if it is in the cache, it already has an actor ID
          Severity: Minor
          Found in includes/user/ActorStore.php - About 1 hr to fix

            Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    ILoadBalancer $loadBalancer,
        UserNameUtils $userNameUtils,
        TempUserConfig $tempUserConfig,
        LoggerInterface $logger,
        HideUserUtils $hideUserUtils,
            Severity: Minor
            Found in includes/user/ActorStore.php - About 45 mins to fix

              Function acquireSystemActorId has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function acquireSystemActorId( UserIdentity $user, IDatabase $dbw ): int {
        $this->checkDatabaseDomain( $dbw );
        [ $userId, $userName ] = $this->validateActorForInsertion( $user );

        $existingActorId = $this->findActorIdInternal( $userName, $dbw );
              Severity: Minor
              Found in includes/user/ActorStore.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status