Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/user/BotPasswordStore.php

Summary

Maintainability
B
6 hrs
Test Coverage

File BotPasswordStore.php has 251 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * BotPassword interaction with databases
 *
 * This program is free software; you can redistribute it and/or modify
Severity: Minor
Found in includes/user/BotPasswordStore.php - About 2 hrs to fix

    Method newUnsavedBotPassword has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function newUnsavedBotPassword(
        array $data,
        int $flags = IDBAccessObject::READ_NORMAL
    ): ?BotPassword {
        if ( isset( $data['user'] ) && ( !$data['user'] instanceof UserIdentity ) ) {
    Severity: Minor
    Found in includes/user/BotPasswordStore.php - About 1 hr to fix

      Method updateBotPassword has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function updateBotPassword(
        BotPassword $botPassword,
        Password $password = null
    ): StatusValue {
        $res = $this->validateBotPassword( $botPassword );
      Severity: Minor
      Found in includes/user/BotPasswordStore.php - About 1 hr to fix

        Method insertBotPassword has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function insertBotPassword(
        BotPassword $botPassword,
        Password $password = null
    ): StatusValue {
        $res = $this->validateBotPassword( $botPassword );
        Severity: Minor
        Found in includes/user/BotPasswordStore.php - About 1 hr to fix

          Function newUnsavedBotPassword has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function newUnsavedBotPassword(
        array $data,
        int $flags = IDBAccessObject::READ_NORMAL
    ): ?BotPassword {
        if ( isset( $data['user'] ) && ( !$data['user'] instanceof UserIdentity ) ) {
          Severity: Minor
          Found in includes/user/BotPasswordStore.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status