wikimedia/mediawiki-core

View on GitHub
includes/user/PasswordReset.php

Summary

Maintainability
D
2 days
Test Coverage

Function execute has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute(
        User $performingUser,
        $username = null,
        $email = null
    ) {
Severity: Minor
Found in includes/user/PasswordReset.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 109 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute(
        User $performingUser,
        $username = null,
        $email = null
    ) {
Severity: Major
Found in includes/user/PasswordReset.php - About 4 hrs to fix

    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            ServiceOptions $config,
            LoggerInterface $logger,
            AuthManager $authManager,
            HookContainer $hookContainer,
            IConnectionProvider $dbProvider,
    Severity: Major
    Found in includes/user/PasswordReset.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                      return StatusValue::newGood();
      Severity: Major
      Found in includes/user/PasswordReset.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return StatusValue::newGood();
        Severity: Major
        Found in includes/user/PasswordReset.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return StatusValue::newGood();
          Severity: Major
          Found in includes/user/PasswordReset.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return StatusValue::newFatal( Message::newFromSpecifier( $error ) );
            Severity: Major
            Found in includes/user/PasswordReset.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return StatusValue::newFatal( 'noname' );
              Severity: Major
              Found in includes/user/PasswordReset.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return StatusValue::newGood();
                Severity: Major
                Found in includes/user/PasswordReset.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return StatusValue::newFatal( 'noname' );
                  Severity: Major
                  Found in includes/user/PasswordReset.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return $result;
                    Severity: Major
                    Found in includes/user/PasswordReset.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return StatusValue::newGood();
                      Severity: Major
                      Found in includes/user/PasswordReset.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return StatusValue::newGood();
                        Severity: Major
                        Found in includes/user/PasswordReset.php - About 30 mins to fix

                          There are no issues that match your filters.

                          Category
                          Status