Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/user/TempUser/TempUserCreator.php

Summary

Maintainability
C
1 day
Test Coverage

TempUserCreator has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class TempUserCreator implements TempUserConfig {
    private RealTempUserConfig $config;
    private UserFactory $userFactory;
    private AuthManager $authManager;
    private CentralIdLookup $centralIdLookup;
Severity: Minor
Found in includes/user/TempUser/TempUserCreator.php - About 2 hrs to fix

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            RealTempUserConfig $config,
        ObjectFactory $objectFactory,
        UserFactory $userFactory,
        AuthManager $authManager,
        CentralIdLookup $centralIdLookup,
    Severity: Minor
    Found in includes/user/TempUser/TempUserCreator.php - About 45 mins to fix

      Function create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function create( $name = null, WebRequest $request = null ): CreateStatus {
        $status = new CreateStatus;
        if ( $request && $this->throttler ) {
            // TODO: This is duplicated from ThrottlePreAuthenticationProvider
            // and should be factored out, see T261744
      Severity: Minor
      Found in includes/user/TempUser/TempUserCreator.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function createSerialMapping(): SerialMapping {
        $type = $this->serialMappingConfig['type'];
        if ( isset( self::SERIAL_MAPPINGS[$type] ) ) {
            $spec = self::SERIAL_MAPPINGS[$type];
        } else {
      Severity: Major
      Found in includes/user/TempUser/TempUserCreator.php and 1 other location - About 3 hrs to fix
      includes/user/TempUser/TempUserCreator.php on lines 255..278

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 145.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private function createSerialProvider(): SerialProvider {
        $type = $this->serialProviderConfig['type'];
        if ( isset( self::SERIAL_PROVIDERS[$type] ) ) {
            $spec = self::SERIAL_PROVIDERS[$type];
        } else {
      Severity: Major
      Found in includes/user/TempUser/TempUserCreator.php and 1 other location - About 3 hrs to fix
      includes/user/TempUser/TempUserCreator.php on lines 295..317

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 145.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status