Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
includes/watchlist/WatchlistManager.php

Summary

Maintainability
B
6 hrs
Test Coverage

File WatchlistManager.php has 252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
Severity: Minor
Found in includes/watchlist/WatchlistManager.php - About 2 hrs to fix

    Method clearTitleUserNotifications has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function clearTitleUserNotifications(
        $performer,
        $title,
        int $oldid = 0,
        RevisionRecord $oldRev = null
    Severity: Minor
    Found in includes/watchlist/WatchlistManager.php - About 1 hr to fix

      Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              array $options,
        HookContainer $hookContainer,
        ReadOnlyMode $readOnlyMode,
        RevisionLookup $revisionLookup,
        TalkPageNotificationManager $talkPageNotificationManager,
      Severity: Major
      Found in includes/watchlist/WatchlistManager.php - About 1 hr to fix

        Function clearTitleUserNotifications has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function clearTitleUserNotifications(
        $performer,
        $title,
        int $oldid = 0,
        RevisionRecord $oldRev = null
        Severity: Minor
        Found in includes/watchlist/WatchlistManager.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setWatch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function setWatch(
        bool $watch,
        Authority $performer,
        PageIdentity $target,
        string $expiry = null
        Severity: Minor
        Found in includes/watchlist/WatchlistManager.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status