Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star

Showing 11,498 of 11,498 total issues

Function doQuotes has a Cognitive Complexity of 76 (exceeds 5 allowed). Consider refactoring.
Open

    public function doQuotes( $text ) {
        $arr = preg_split( "/(''+)/", $text, -1, PREG_SPLIT_DELIM_CAPTURE );
        $countarr = count( $arr );
        if ( $countarr == 1 ) {
            return $text;
Severity: Minor
Found in includes/parser/Parser.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File FSFileBackend.php has 668 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Major
Found in includes/libs/filebackend/FSFileBackend.php - About 1 day to fix

    Method run has 299 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function run( ApiPageSet $resultPageSet = null ) {
        $db = $this->getDB();
        $params = $this->extractRequestParams( false );

        $result = $this->getResult();
    Severity: Major
    Found in includes/api/ApiQueryAllDeletedRevisions.php - About 1 day to fix

      Method getFieldDefinitions has 298 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getFieldDefinitions( array $fieldInfo ) {
        $isLoggedIn = $this->getUser()->isRegistered();
        $continuePart = $this->isContinued() ? 'continue-' : '';
        $anotherPart = $isLoggedIn ? 'another-' : '';
        // @phan-suppress-next-line PhanUndeclaredMethod
      Severity: Major
      Found in includes/specialpage/LoginSignupSpecialPage.php - About 1 day to fix

        ApiBase has 79 functions (exceeds 20 allowed). Consider refactoring.
        Open

        abstract class ApiBase extends ContextSource {

    use ApiBlockInfoTrait;

    /** @var HookContainer */
        Severity: Major
        Found in includes/api/ApiBase.php - About 1 day to fix

          Function wikiTextToAst has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
          Open

              wikiTextToAst: function ( input ) {
        var pos,
            regularLiteral, regularLiteralWithoutBar, regularLiteralWithoutSpace, regularLiteralWithSquareBrackets,
            doubleQuote, singleQuote, backslash, anyCharacter, asciiAlphabetLiteral,
            escapedOrLiteralWithoutSpace, escapedOrLiteralWithoutBar, escapedOrRegularLiteral,
          Severity: Minor
          Found in resources/src/mediawiki.jqueryMsg/mediawiki.jqueryMsg.js - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function execute has a Cognitive Complexity of 74 (exceeds 5 allowed). Consider refactoring.
          Open

              public function execute() {
        $params = $this->extractRequestParams();
        $activeUserDays = $this->getConfig()->get( MainConfigNames::ActiveUserDays );

        $db = $this->getDB();
          Severity: Minor
          Found in includes/api/ApiQueryAllUsers.php - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File MovePage.php has 655 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
          Severity: Major
          Found in includes/page/MovePage.php - About 1 day to fix

            File Maintenance.php has 655 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
            Severity: Major
            Found in maintenance/includes/Maintenance.php - About 1 day to fix

              Method buildContentNavigationUrlsInternal has 291 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function buildContentNavigationUrlsInternal() {
        if ( $this->contentNavigationCached ) {
            return $this->contentNavigationCached;
        }
        // Display tabs for the relevant title rather than always the title itself
              Severity: Major
              Found in includes/skins/SkinTemplate.php - About 1 day to fix

                File WebRequest.php has 651 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
/**
 * Deal with importing all those nasty globals and things
 *
 * Copyright © 2003 Brooke Vibber <bvibber@wikimedia.org>
                Severity: Major
                Found in includes/Request/WebRequest.php - About 1 day to fix

                  File ContentHandler.php has 650 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php

/**
 * Base class for content handling.
 *
                  Severity: Major
                  Found in includes/content/ContentHandler.php - About 1 day to fix

                    Function pageInfo has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function pageInfo() {
        $user = $this->getUser();
        $lang = $this->getLanguage();
        $title = $this->getTitle();
        $id = $title->getArticleID();
                    Severity: Minor
                    Found in includes/actions/InfoAction.php - About 1 day to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function execute has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function execute() {
        $db = $this->getDB();
        $params = $this->extractRequestParams();
        $this->requireMaxOneParameter( $params, 'users', 'ip' );
                    Severity: Minor
                    Found in includes/api/ApiQueryBlocks.php - About 1 day to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function recXmlPrint has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static function recXmlPrint( $name, $value, $indent, $attributes = [] ) {
        $retval = '';
        if ( $indent !== null ) {
            if ( $name !== null ) {
                $indent += 2;
                    Severity: Minor
                    Found in includes/api/ApiFormatXml.php - About 1 day to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function makeImageLink has a Cognitive Complexity of 73 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public static function makeImageLink( Parser $parser, LinkTarget $title,
        $file, $frameParams = [], $handlerParams = [], $time = false,
        $query = '', $widthOption = null
    ) {
        $title = Title::newFromLinkTarget( $title );
                    Severity: Minor
                    Found in includes/linker/Linker.php - About 1 day to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method run has 288 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function run( $resultPageSet = null ) {
        $user = $this->getUser();
        /* Get the parameters of the request. */
        $params = $this->extractRequestParams();
                    Severity: Major
                    Found in includes/api/ApiQueryRecentChanges.php - About 1 day to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                      if ( word.slice( -1 ) === 'ь' ) {
                    word = word.slice( 0, -1 ) + 'я';
                } else if ( word.slice( -2 ) === 'ия' ) {
                    word = word.slice( 0, -2 ) + 'ии';
                } else if ( word.slice( -2 ) === 'ка' ) {
                      Severity: Major
                      Found in resources/lib/jquery.i18n/src/languages/ru.js and 1 other location - About 1 day to fix
                      resources/lib/jquery.i18n/src/languages/uk.js on lines 12..24

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 265.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                          if ( word.slice( -1 ) === 'ь' ) {
                        word = word.slice( 0, -1 ) + 'я';
                    } else if ( word.slice( -2 ) === 'ія' ) {
                        word = word.slice( 0, -2 ) + 'ії';
                    } else if ( word.slice( -2 ) === 'ка' ) {
                      Severity: Major
                      Found in resources/lib/jquery.i18n/src/languages/uk.js and 1 other location - About 1 day to fix
                      resources/lib/jquery.i18n/src/languages/ru.js on lines 11..23

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 265.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      File TransactionManager.php has 644 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
                      Severity: Major
                      Found in includes/libs/rdbms/database/TransactionManager.php - About 1 day to fix
                        Severity
                        Category
                        Status
                        Source
                        Language