Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/categoryChangesAsRdf.php

Summary

Maintainability
F
3 days
Test Coverage

File categoryChangesAsRdf.php has 418 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in maintenance/categoryChangesAsRdf.php - About 6 hrs to fix

    Function handleCategorization has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

        public function handleCategorization( IReadableDatabase $dbr, $output ) {
        $processedTitle = [];

        // Categorization change can add new parents and change counts
        // for the parent category.
    Severity: Minor
    Found in maintenance/categoryChangesAsRdf.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handleCategorization has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function handleCategorization( IReadableDatabase $dbr, $output ) {
        $processedTitle = [];

        // Categorization change can add new parents and change counts
        // for the parent category.
    Severity: Major
    Found in maintenance/categoryChangesAsRdf.php - About 2 hrs to fix

      CategoryChangesAsRdf has 24 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class CategoryChangesAsRdf extends Maintenance {
    /**
     * Insert query
     */
    private const SPARQL_INSERT = <<<SPARQL
      Severity: Minor
      Found in maintenance/categoryChangesAsRdf.php - About 2 hrs to fix

        Function handleMoves has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function handleMoves( IReadableDatabase $dbr, $output ) {
        foreach ( $this->getMovedCatsIterator( $dbr, __METHOD__ ) as $batch ) {
            $pages = [];
            $deleteUrls = [];
            foreach ( $batch as $row ) {
        Severity: Minor
        Found in maintenance/categoryChangesAsRdf.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method execute has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function execute() {
        $this->initialize();
        $startTS = new MWTimestamp( $this->getOption( "start" ) );

        $endTS = new MWTimestamp( $this->getOption( "end" ) );
        Severity: Minor
        Found in maintenance/categoryChangesAsRdf.php - About 1 hr to fix

          Method setupChangesIterator has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function setupChangesIterator(
        IReadableDatabase $dbr,
        array $columns = [],
        array $extra_tables = [],
        $fname = __METHOD__
          Severity: Minor
          Found in maintenance/categoryChangesAsRdf.php - About 1 hr to fix

            Function handleAdds has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function handleAdds( IReadableDatabase $dbr, $output ) {
        fwrite( $output, "# Additions\n" );

        foreach ( $this->getNewCatsIterator( $dbr, __METHOD__ ) as $batch ) {
            $pages = [];
            Severity: Minor
            Found in maintenance/categoryChangesAsRdf.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function handleRestores has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function handleRestores( IReadableDatabase $dbr, $output ) {
        fwrite( $output, "# Restores\n" );

        // This will only find those restores that were not deleted later.
        foreach ( $this->getRestoredCatsIterator( $dbr, __METHOD__ ) as $batch ) {
            Severity: Minor
            Found in maintenance/categoryChangesAsRdf.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function handleEdits has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function handleEdits( IReadableDatabase $dbr, $output ) {
        // Editing category can change hidden flag and add new parents.
        // TODO: it's pretty expensive to update all edited categories, and most edits
        // aren't actually interesting for us. Some way to know which are interesting?
        // We can capture recategorization on the next step, but not change in hidden status.
            Severity: Minor
            Found in maintenance/categoryChangesAsRdf.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function handleAdds( IReadableDatabase $dbr, $output ) {
        fwrite( $output, "# Additions\n" );

        foreach ( $this->getNewCatsIterator( $dbr, __METHOD__ ) as $batch ) {
            $pages = [];
            Severity: Major
            Found in maintenance/categoryChangesAsRdf.php and 1 other location - About 3 hrs to fix
            maintenance/categoryChangesAsRdf.php on lines 501..525

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 151.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                public function handleRestores( IReadableDatabase $dbr, $output ) {
        fwrite( $output, "# Restores\n" );

        // This will only find those restores that were not deleted later.
        foreach ( $this->getRestoredCatsIterator( $dbr, __METHOD__ ) as $batch ) {
            Severity: Major
            Found in maintenance/categoryChangesAsRdf.php and 1 other location - About 3 hrs to fix
            maintenance/categoryChangesAsRdf.php on lines 531..553

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 151.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status