Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/cleanupImages.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method pokeFile has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function pokeFile( $orig, $new ) {
        $path = $this->filePath( $orig );
        if ( !file_exists( $path ) ) {
            $this->output( "missing file: $path\n" );
            $this->killRow( $orig );
Severity: Minor
Found in maintenance/cleanupImages.php - About 2 hrs to fix

    Function pokeFile has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        private function pokeFile( $orig, $new ) {
        $path = $this->filePath( $orig );
        if ( !file_exists( $path ) ) {
            $this->output( "missing file: $path\n" );
            $this->killRow( $orig );
    Severity: Minor
    Found in maintenance/cleanupImages.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method processRow has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function processRow( $row ) {
        $source = $row->img_name;
        if ( $source == '' ) {
            // Ye olde empty rows. Just kill them.
            $this->killRow( $source );
    Severity: Minor
    Found in maintenance/cleanupImages.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status