Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/cleanupTitles.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function moveInconsistentPage has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    protected function moveInconsistentPage( $row, Title $title ) {
        if ( $title->exists( IDBAccessObject::READ_LATEST )
            || $title->getInterwiki()
            || !$title->canExist()
        ) {
Severity: Minor
Found in maintenance/cleanupTitles.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method moveInconsistentPage has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function moveInconsistentPage( $row, Title $title ) {
        if ( $title->exists( IDBAccessObject::READ_LATEST )
            || $title->getInterwiki()
            || !$title->canExist()
        ) {
Severity: Major
Found in maintenance/cleanupTitles.php - About 2 hrs to fix

    Method moveIllegalPage has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function moveIllegalPage( $row ) {
        $legal = 'A-Za-z0-9_/\\\\-';
        $legalized = preg_replace_callback( "!([^$legal])!",
            [ $this, 'hexChar' ],
            $row->page_title );
    Severity: Minor
    Found in maintenance/cleanupTitles.php - About 1 hr to fix

      Function moveIllegalPage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function moveIllegalPage( $row ) {
        $legal = 'A-Za-z0-9_/\\\\-';
        $legalized = preg_replace_callback( "!([^$legal])!",
            [ $this, 'hexChar' ],
            $row->page_title );
      Severity: Minor
      Found in maintenance/cleanupTitles.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function processRow has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function processRow( $row ) {
        $display = Title::makeName( $row->page_namespace, $row->page_title );
        $verified = $this->getServiceContainer()->getContentLanguage()->normalize( $display );
        $title = Title::newFromText( $verified );
      Severity: Minor
      Found in maintenance/cleanupTitles.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status