Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/deleteAutoPatrolLogs.php

Summary

Maintainability
C
1 day
Test Coverage

Function execute has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        $this->setBatchSize( $this->getOption( 'batch-size', $this->getBatchSize() ) );

        $sleep = (int)$this->getOption( 'sleep', 10 );
        $fromId = $this->getOption( 'from-id', null );
Severity: Minor
Found in maintenance/deleteAutoPatrolLogs.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getRowsOld has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    private function getRowsOld( $fromId ) {
        $dbr = $this->getReplicaDB();
        $batchSize = $this->getBatchSize();
        $before = $this->getOption( 'before', false );
Severity: Minor
Found in maintenance/deleteAutoPatrolLogs.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getRowsOld has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getRowsOld( $fromId ) {
        $dbr = $this->getReplicaDB();
        $batchSize = $this->getBatchSize();
        $before = $this->getOption( 'before', false );
Severity: Minor
Found in maintenance/deleteAutoPatrolLogs.php - About 1 hr to fix

    Method execute has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute() {
        $this->setBatchSize( $this->getOption( 'batch-size', $this->getBatchSize() ) );

        $sleep = (int)$this->getOption( 'sleep', 10 );
        $fromId = $this->getOption( 'from-id', null );
    Severity: Minor
    Found in maintenance/deleteAutoPatrolLogs.php - About 1 hr to fix

      Method __construct has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct() {
        parent::__construct();
        $this->addDescription( 'Remove autopatrol logs in the logging table' );
        $this->addOption( 'dry-run', 'Print debug info instead of actually deleting' );
        $this->addOption(
      Severity: Minor
      Found in maintenance/deleteAutoPatrolLogs.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status