Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/findBadBlobs.php

Summary

Maintainability
C
1 day
Test Coverage

File findBadBlobs.php has 297 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
Severity: Minor
Found in maintenance/findBadBlobs.php - About 3 hrs to fix

    Method scanRevisionsByTimestamp has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function scanRevisionsByTimestamp( $fromTimestamp, $total ) {
        $count = 0;
        $lastRevId = 0;
        $firstRevId = 0;
        $lastTimestamp = $fromTimestamp;
    Severity: Major
    Found in maintenance/findBadBlobs.php - About 2 hrs to fix

      Function execute has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function execute() {
        $services = $this->getServiceContainer();
        $this->revisionStore = $services->getRevisionStore();
        $this->blobStore = $services->getBlobStore();
        $this->setDBProvider( $services->getConnectionProvider() );
      Severity: Minor
      Found in maintenance/findBadBlobs.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function scanRevisionsByTimestamp has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          private function scanRevisionsByTimestamp( $fromTimestamp, $total ) {
        $count = 0;
        $lastRevId = 0;
        $firstRevId = 0;
        $lastTimestamp = $fromTimestamp;
      Severity: Minor
      Found in maintenance/findBadBlobs.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method execute has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function execute() {
        $services = $this->getServiceContainer();
        $this->revisionStore = $services->getRevisionStore();
        $this->blobStore = $services->getBlobStore();
        $this->setDBProvider( $services->getConnectionProvider() );
      Severity: Minor
      Found in maintenance/findBadBlobs.php - About 1 hr to fix

        Function scanRevisionsById has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private function scanRevisionsById( array $ids ) {
        $count = 0;
        $total = count( $ids );

        $this->output( "Scanning $total ids\n" );
        Severity: Minor
        Found in maintenance/findBadBlobs.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status