Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/findOrphanedFiles.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function checkFiles has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected function checkFiles( LocalRepo $repo, array $paths, $verbose ) {
        if ( !count( $paths ) ) {
            return;
        }
Severity: Minor
Found in maintenance/findOrphanedFiles.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkFiles has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function checkFiles( LocalRepo $repo, array $paths, $verbose ) {
        if ( !count( $paths ) ) {
            return;
        }
Severity: Major
Found in maintenance/findOrphanedFiles.php - About 2 hrs to fix

    Method execute has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute() {
        $subdir = $this->getOption( 'subdir', '' );
        $verbose = $this->hasOption( 'verbose' );

        $repo = $this->getServiceContainer()->getRepoGroup()->getLocalRepo();
    Severity: Minor
    Found in maintenance/findOrphanedFiles.php - About 1 hr to fix

      Function execute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function execute() {
        $subdir = $this->getOption( 'subdir', '' );
        $verbose = $this->hasOption( 'verbose' );

        $repo = $this->getServiceContainer()->getRepoGroup()->getLocalRepo();
      Severity: Minor
      Found in maintenance/findOrphanedFiles.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status