Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/generateSitemap.php

Summary

Maintainability
D
2 days
Test Coverage

Function main has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

    public function main() {
        $services = $this->getServiceContainer();
        $contLang = $services->getContentLanguage();
        $langConverter = $services->getLanguageConverterFactory()->getLanguageConverter( $contLang );
        $serverUrl = $services->getUrlUtils()->getServer( PROTO_CANONICAL ) ?? '';
Severity: Minor
Found in maintenance/generateSitemap.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File generateSitemap.php has 307 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Creates a sitemap for the site.
 *
 * Copyright © 2005, Ævar Arnfjörð Bjarmason, Jens Frank <jeluf@gmx.de> and
Severity: Minor
Found in maintenance/generateSitemap.php - About 3 hrs to fix

    Method main has 74 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function main() {
        $services = $this->getServiceContainer();
        $contLang = $services->getContentLanguage();
        $langConverter = $services->getLanguageConverterFactory()->getLanguageConverter( $contLang );
        $serverUrl = $services->getUrlUtils()->getServer( PROTO_CANONICAL ) ?? '';
    Severity: Major
    Found in maintenance/generateSitemap.php - About 2 hrs to fix

      GenerateSitemap has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class GenerateSitemap extends Maintenance {
    private const GS_MAIN = -2;
    private const GS_TALK = -1;

    /**
      Severity: Minor
      Found in maintenance/generateSitemap.php - About 2 hrs to fix

        Method __construct has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __construct() {
        parent::__construct();
        $this->addDescription( 'Creates a sitemap for the site' );
        $this->addOption(
            'fspath',
        Severity: Minor
        Found in maintenance/generateSitemap.php - About 1 hr to fix

          Method setNamespacePriorities has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function setNamespacePriorities() {
        $sitemapNamespacesPriorities = $this->getConfig()->get( MainConfigNames::SitemapNamespacesPriorities );

        // Custom main namespaces
        $this->priorities[self::GS_MAIN] = '0.5';
          Severity: Minor
          Found in maintenance/generateSitemap.php - About 1 hr to fix

            Function setNamespacePriorities has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function setNamespacePriorities() {
        $sitemapNamespacesPriorities = $this->getConfig()->get( MainConfigNames::SitemapNamespacesPriorities );

        // Custom main namespaces
        $this->priorities[self::GS_MAIN] = '0.5';
            Severity: Minor
            Found in maintenance/generateSitemap.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status