Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/getConfiguration.php

Summary

Maintainability
C
1 day
Test Coverage

Function execute has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        // Settings we will display
        $res = [];

        # Default: dump any wg / wmg variable
Severity: Minor
Found in maintenance/getConfiguration.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateParamsAndArgs has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function validateParamsAndArgs() {
        $error_out = false;

        # Get the format and make sure it is set to a valid default value
        $format = strtolower( $this->getOption( 'format', 'PHP' ) );
Severity: Minor
Found in maintenance/getConfiguration.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        // Settings we will display
        $res = [];

        # Default: dump any wg / wmg variable
Severity: Minor
Found in maintenance/getConfiguration.php - About 1 hr to fix

    Method validateParamsAndArgs has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function validateParamsAndArgs() {
        $error_out = false;

        # Get the format and make sure it is set to a valid default value
        $format = strtolower( $this->getOption( 'format', 'PHP' ) );
    Severity: Minor
    Found in maintenance/getConfiguration.php - About 1 hr to fix

      Function isAllowedVariable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function isAllowedVariable( $value ) {
        if ( is_array( $value ) ) {
            foreach ( $value as $v ) {
                if ( !$this->isAllowedVariable( $v ) ) {
                    return false;
      Severity: Minor
      Found in maintenance/getConfiguration.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status