Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/importImages.php

Summary

Maintainability
F
5 days
Test Coverage

Function execute has a Cognitive Complexity of 109 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        $services = $this->getServiceContainer();
        $permissionManager = $services->getPermissionManager();

        $found = 0;
Severity: Minor
Found in maintenance/importImages.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 250 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        $services = $this->getServiceContainer();
        $permissionManager = $services->getPermissionManager();

        $found = 0;
Severity: Major
Found in maintenance/importImages.php - About 1 day to fix

    File importImages.php has 398 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * Import one or more images from the local file system into the wiki without
 * using the web-based interface.
 *
    Severity: Minor
    Found in maintenance/importImages.php - About 5 hrs to fix

      Method __construct has 79 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct() {
        parent::__construct();

        $this->addDescription( 'Imports images and other media files into the wiki' );
        $this->addArg( 'dir', 'Path to the directory containing images to be imported' );
      Severity: Major
      Found in maintenance/importImages.php - About 3 hrs to fix

        Function findFiles has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            private function findFiles( $dir, $exts, $recurse = false ) {
        $dhl = is_dir( $dir ) ? opendir( $dir ) : false;
        if ( !$dhl ) {
            return;
        }
        Severity: Minor
        Found in maintenance/importImages.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function findAuxFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function findAuxFile( $file, $auxExtension, $maxStrip = 1 ) {
        if ( !str_starts_with( $auxExtension, '.' ) ) {
            $auxExtension = '.' . $auxExtension;
        }
        Severity: Minor
        Found in maintenance/importImages.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private function getFileCommentFromSourceWiki( $wiki_host, $file ) {
        $url = $wiki_host . '/api.php?action=query&format=xml&titles=File:'
            . rawurlencode( $file ) . '&prop=imageinfo&&iiprop=comment';
        $body = $this->getServiceContainer()->getHttpRequestFactory()->get( $url, [], __METHOD__ );
        if ( preg_match( '#<ii comment="([^"]*)" />#', $body, $matches ) == 0 ) {
        Severity: Major
        Found in maintenance/importImages.php and 1 other location - About 1 hr to fix
        maintenance/importImages.php on lines 513..522

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private function getFileUserFromSourceWiki( $wiki_host, $file ) {
        $url = $wiki_host . '/api.php?action=query&format=xml&titles=File:'
            . rawurlencode( $file ) . '&prop=imageinfo&&iiprop=user';
        $body = $this->getServiceContainer()->getHttpRequestFactory()->get( $url, [], __METHOD__ );
        if ( preg_match( '#<ii user="([^"]*)" />#', $body, $matches ) == 0 ) {
        Severity: Major
        Found in maintenance/importImages.php and 1 other location - About 1 hr to fix
        maintenance/importImages.php on lines 502..511

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 106.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status