Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/includes/BackupDumper.php

Summary

Maintainability
D
2 days
Test Coverage

Function processOptions has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    protected function processOptions() {
        $sink = null;
        $sinks = [];

        $this->schemaVersion = WikiExporter::schemaVersion();
Severity: Minor
Found in maintenance/includes/BackupDumper.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File BackupDumper.php has 318 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Base classes for database-dumping maintenance scripts.
 *
 * Copyright © 2005 Brooke Vibber <bvibber@wikimedia.org>
Severity: Minor
Found in maintenance/includes/BackupDumper.php - About 3 hrs to fix

    Method processOptions has 77 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function processOptions() {
        $sink = null;
        $sinks = [];

        $this->schemaVersion = WikiExporter::schemaVersion();
    Severity: Major
    Found in maintenance/includes/BackupDumper.php - About 3 hrs to fix

      Function dump has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public function dump( $history, $text = WikiExporter::TEXT ) {
        # Notice messages will foul up your XML output even if they're
        # relatively harmless.
        if ( ini_get( 'display_errors' ) ) {
            ini_set( 'display_errors', 'stderr' );
      Severity: Minor
      Found in maintenance/includes/BackupDumper.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method dump has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function dump( $history, $text = WikiExporter::TEXT ) {
        # Notice messages will foul up your XML output even if they're
        # relatively harmless.
        if ( ini_get( 'display_errors' ) ) {
            ini_set( 'display_errors', 'stderr' );
      Severity: Minor
      Found in maintenance/includes/BackupDumper.php - About 1 hr to fix

        Method showReport has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function showReport() {
        if ( $this->reporting ) {
            $now = wfTimestamp( TS_DB );
            $nowts = microtime( true );
            $deltaAll = $nowts - $this->startTime;
        Severity: Minor
        Found in maintenance/includes/BackupDumper.php - About 1 hr to fix

          Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function __construct( $args = null ) {
        parent::__construct();
        $this->stderr = fopen( "php://stderr", "wt" );

        // Built-in output and filter plugins
          Severity: Minor
          Found in maintenance/includes/BackupDumper.php - About 1 hr to fix

            Function showReport has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function showReport() {
        if ( $this->reporting ) {
            $now = wfTimestamp( TS_DB );
            $nowts = microtime( true );
            $deltaAll = $nowts - $this->startTime;
            Severity: Minor
            Found in maintenance/includes/BackupDumper.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status