Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/migrateLinksTable.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method handlePageBatch has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function handlePageBatch( $lowPageId, $mapping, $table ) {
        $batchSize = $this->getBatchSize();
        $targetColumn = $mapping[$table]['target_id'];
        $pageIdColumn = $mapping[$table]['page_id'];
        // range is inclusive, let's subtract one.
Severity: Minor
Found in maintenance/migrateLinksTable.php - About 1 hr to fix

    Method doDBUpdates has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function doDBUpdates() {
        $dbw = $this->getDB( DB_PRIMARY );
        $mapping = \MediaWiki\Linker\LinksMigration::$mapping;
        $table = $this->getOption( 'table', '' );
        if ( !isset( $mapping[$table] ) ) {
    Severity: Minor
    Found in maintenance/migrateLinksTable.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in maintenance/migrateLinksTable.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return true;
        Severity: Major
        Found in maintenance/migrateLinksTable.php - About 30 mins to fix

          Function doDBUpdates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function doDBUpdates() {
        $dbw = $this->getDB( DB_PRIMARY );
        $mapping = \MediaWiki\Linker\LinksMigration::$mapping;
        $table = $this->getOption( 'table', '' );
        if ( !isset( $mapping[$table] ) ) {
          Severity: Minor
          Found in maintenance/migrateLinksTable.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handlePageBatch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private function handlePageBatch( $lowPageId, $mapping, $table ) {
        $batchSize = $this->getBatchSize();
        $targetColumn = $mapping[$table]['target_id'];
        $pageIdColumn = $mapping[$table]['page_id'];
        // range is inclusive, let's subtract one.
          Severity: Minor
          Found in maintenance/migrateLinksTable.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status