maintenance/mysql.php
Function execute
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
Open
public function execute() {
$dbName = $this->getOption( 'wikidb', false );
$lbf = $this->getServiceContainer()->getDBLoadBalancerFactory();
// Pick LB
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method runMysql
has 52 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private function runMysql( $info, $dbName ) {
// Write the password to an option file to avoid disclosing it to other
// processes running on the system
$tmpFile = TempFSFile::factory( 'mw-mysql', 'ini' );
chmod( $tmpFile->getPath(), 0600 );
Method execute
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function execute() {
$dbName = $this->getOption( 'wikidb', false );
$lbf = $this->getServiceContainer()->getDBLoadBalancerFactory();
// Pick LB
Function runMysql
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
Open
private function runMysql( $info, $dbName ) {
// Write the password to an option file to avoid disclosing it to other
// processes running on the system
$tmpFile = TempFSFile::factory( 'mw-mysql', 'ini' );
chmod( $tmpFile->getPath(), 0600 );
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"