Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/recountCategories.php

Summary

Maintainability
B
6 hrs
Test Coverage

Method doWork has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function doWork( $mode ) {
        $this->output( "Finding up to {$this->getBatchSize()} drifted rows " .
            "greater than cat_id {$this->minimumId}...\n" );

        $dbr = $this->getDB( DB_REPLICA, 'vslow' );
Severity: Minor
Found in maintenance/recountCategories.php - About 1 hr to fix

    Method execute has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function execute() {
        $originalMode = $this->getOption( 'mode' );
        if ( !in_array( $originalMode, [ 'pages', 'subcats', 'files', 'all' ] ) ) {
            $this->fatalError( 'Please specify a valid mode: one of "pages", "subcats", "files" or "all".' );
        }
    Severity: Minor
    Found in maintenance/recountCategories.php - About 1 hr to fix

      Method __construct has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct() {
        parent::__construct();
        $this->addDescription( <<<'TEXT'
This script refreshes the category membership counts stored in the category
table. As time passes, these counts often drift from the actual number of
      Severity: Minor
      Found in maintenance/recountCategories.php - About 1 hr to fix

        Function execute has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function execute() {
        $originalMode = $this->getOption( 'mode' );
        if ( !in_array( $originalMode, [ 'pages', 'subcats', 'files', 'all' ] ) ) {
            $this->fatalError( 'Please specify a valid mode: one of "pages", "subcats", "files" or "all".' );
        }
        Severity: Minor
        Found in maintenance/recountCategories.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status