maintenance/removeUnusedAccounts.php
Method execute
has 119 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
public function execute() {
$services = $this->getServiceContainer();
$userFactory = $services->getUserFactory();
$userGroupManager = $services->getUserGroupManager();
$this->output( "Remove unused accounts\n\n" );
Function execute
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
Open
public function execute() {
$services = $this->getServiceContainer();
$userFactory = $services->getUserFactory();
$userGroupManager = $services->getUserGroupManager();
$this->output( "Remove unused accounts\n\n" );
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method isInactiveAccount
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
private function isInactiveAccount( $user, $actor, $primary = false ) {
if ( $actor === null ) {
// There's no longer a way for a user to be active in any of
// these tables without having an actor ID. The only way to link
// to a user row is via an actor row.