Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/renameUsersMatchingPattern.php

Summary

Maintainability
C
1 day
Test Coverage

Method execute has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        $this->initServices();

        $fromPattern = new Pattern( 'from', $this->getOption( 'from' ) );
        $toPattern = new Pattern( 'to', $this->getOption( 'to' ) );
Severity: Major
Found in maintenance/renameUsersMatchingPattern.php - About 2 hrs to fix

    Function execute has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function execute() {
        $this->initServices();

        $fromPattern = new Pattern( 'from', $this->getOption( 'from' ) );
        $toPattern = new Pattern( 'to', $this->getOption( 'to' ) );
    Severity: Minor
    Found in maintenance/renameUsersMatchingPattern.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method movePageAndSubpages has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function movePageAndSubpages( $ns, $nsName, $oldName, $newName ) {
        $oldTitle = $this->titleFactory->makeTitleSafe( $ns, $oldName );
        if ( !$oldTitle ) {
            $this->output( "[[$nsName:$oldName]] is an invalid title, can't move it.\n" );
            return true;
    Severity: Minor
    Found in maintenance/renameUsersMatchingPattern.php - About 1 hr to fix

      Function movePageAndSubpages has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          private function movePageAndSubpages( $ns, $nsName, $oldName, $newName ) {
        $oldTitle = $this->titleFactory->makeTitleSafe( $ns, $oldName );
        if ( !$oldTitle ) {
            $this->output( "[[$nsName:$oldName]] is an invalid title, can't move it.\n" );
            return true;
      Severity: Minor
      Found in maintenance/renameUsersMatchingPattern.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method renameUser has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function renameUser( $oldName, $newName ) {
        $id = $this->userFactory->newFromName( $oldName )->getId();
        if ( !$id ) {
            $this->output( "Cannot rename non-existent user \"$oldName\"" );
        }
      Severity: Minor
      Found in maintenance/renameUsersMatchingPattern.php - About 1 hr to fix

        Function renameUser has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function renameUser( $oldName, $newName ) {
        $id = $this->userFactory->newFromName( $oldName )->getId();
        if ( !$id ) {
            $this->output( "Cannot rename non-existent user \"$oldName\"" );
        }
        Severity: Minor
        Found in maintenance/renameUsersMatchingPattern.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status