Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
maintenance/sql.php

Summary

Maintainability
C
1 day
Test Coverage

Function execute has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        global $IP;

        // We want to allow "" for the wikidb, meaning don't call select_db()
        $wiki = $this->hasOption( 'wikidb' ) ? $this->getOption( 'wikidb' ) : false;
Severity: Minor
Found in maintenance/sql.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method execute has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function execute() {
        global $IP;

        // We want to allow "" for the wikidb, meaning don't call select_db()
        $wiki = $this->hasOption( 'wikidb' ) ? $this->getOption( 'wikidb' ) : false;
Severity: Major
Found in maintenance/sql.php - About 3 hrs to fix

    Function sqlPrintResult has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function sqlPrintResult( $res, $db ) {
        if ( !$res ) {
            // Do nothing
            return null;
        } elseif ( is_object( $res ) ) {
    Severity: Minor
    Found in maintenance/sql.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status