wikimedia/mediawiki-core

Function ajax has 70 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        ajax: function ( parameters, ajaxOptions ) {
            const api = this,
                apiDeferred = $.Deferred();

            parameters = Object.assign( {}, this.defaults.parameters, parameters );

File index.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.

Open

( function () {
    /**
     * @typedef {Object} mw.Api.Options
     * @property {Object} [parameters = { action: 'query', format: 'json' }] Default query
     *  parameters for API requests

Function postWithToken has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        postWithToken: function ( tokenType, params, ajaxOptions ) {
            const api = this,
                assertParams = {
                    assert: params.assert,
                    assertuser: params.assertuser

Function getToken has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        getToken: function ( type, additionalParams ) {
            type = mapLegacyToken( type );
            if ( typeof additionalParams === 'string' ) {
                additionalParams = { assert: additionalParams };
            }

Function getErrorMessage has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        getErrorMessage: function ( data ) {
            if (
                data === undefined || data === null || data === '' ||
                // The #ajax method returns the data like this, it's not my fault...
                data === 'OK response but empty result (check HTTP headers?)'

Avoid too many return statements within this function.

Open

                    return $( '<div>' ).append( mw.message( 'api-clientside-error-http', data.xhr.status ).parseDom() );

Avoid too many return statements within this function.

Open

                return $( '<div>' ).text( data.error.info );

Avoid too many return statements within this function.

Open

                return $( data.errors.map( ( err ) => {
                    // formatversion: 1 / 2
                    const $node = $( '<div>' ).html( err[ '*' ] || err.html );
                    return $node[ 0 ];
                } ) );

Avoid too many return statements within this function.

Open

                    return $( '<div>' ).append( mw.message( 'api-clientside-error-noconnect' ).parseDom() );

Avoid too many return statements within this function.

Open

                return $( '<div>' ).append( mw.message( 'api-clientside-error-invalidresponse' ).parseDom() );

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        abort: function () {
            this.requests.forEach( ( request ) => {
                if ( request ) {
                    request.abort();
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        get: function ( parameters, ajaxOptions ) {
            ajaxOptions = ajaxOptions || {};
            ajaxOptions.type = 'GET';
            return this.ajax( parameters, ajaxOptions );
        },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        post: function ( parameters, ajaxOptions ) {
            ajaxOptions = ajaxOptions || {};
            ajaxOptions.type = 'POST';
            return this.ajax( parameters, ajaxOptions );
        },

• Read up
  Read up