Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.authenticationPopup/AuthPopup.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function showDialog has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    showDialog( config ) {
        const { initOpenWindow, openWindow, data } = config;

        // Display a message in the current browser window, so that if the popup window doesn't open,
        // or if the user loses it on their desktop somehow, they can still see what was supposed to happen,
Severity: Major
Found in resources/src/mediawiki.authenticationPopup/AuthPopup.js - About 2 hrs to fix

    Function openBrowserWindowCoveringElement has 53 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function openBrowserWindowCoveringElement( url, el, mouseEvent ) {
    // Tested on:
    // * Windows 10 22H2, Firefox and Edge, 100% and 200% scale screens, -/=/+ zoom
    //   All good.
    // * Windows 10 22H2, Firefox and Edge, 150% scale screen, -/=/+ zoom (another device, tablet)
    Severity: Major
    Found in resources/src/mediawiki.authenticationPopup/AuthPopup.js - About 2 hrs to fix

      Function openBrowserWindowCoveringElement has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function openBrowserWindowCoveringElement( url, el, mouseEvent ) {
    // Tested on:
    // * Windows 10 22H2, Firefox and Edge, 100% and 200% scale screens, -/=/+ zoom
    //   All good.
    // * Windows 10 22H2, Firefox and Edge, 150% scale screen, -/=/+ zoom (another device, tablet)
      Severity: Minor
      Found in resources/src/mediawiki.authenticationPopup/AuthPopup.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function startIframe has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          startIframe() {
        const $iframe = $( '<iframe>' )
            .attr( 'src', this.loginPopupUrl )
            .css( {
                border: '0',
      Severity: Minor
      Found in resources/src/mediawiki.authenticationPopup/AuthPopup.js - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status