Sign upLogin

wikimedia/mediawiki-core

View on GitHub
Star
resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js

Summary

Maintainability
D
2 days
Test Coverage

Function MWWDateInputWidget has 113 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    mw.widgets.DateInputWidget = function MWWDateInputWidget( config ) {
        // Config initialization
        config = $.extend( {
            precision: 'day',
            longDisplayFormat: false,
Severity: Major
Found in resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js - About 4 hrs to fix

    File mw.widgets.DateInputWidget.js has 347 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*!
 * MediaWiki Widgets – DateInputWidget class.
 *
 * @copyright 2011-2015 MediaWiki Widgets Team and others; see AUTHORS.txt
 * @license The MIT License (MIT); see LICENSE.txt
    Severity: Minor
    Found in resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          mw.widgets.DateInputWidget.prototype.setValidityFlag = function ( isValid ) {
        var widget = this,
            setFlag = function ( valid ) {
                if ( !valid ) {
                    widget.$input.attr( 'aria-invalid', 'true' );
      Severity: Major
      Found in resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js and 1 other location - About 6 hrs to fix
      resources/lib/ooui/oojs-ui-core.js on lines 11923..11943

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 174.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if ( !this.isDisabled() && !this.isReadOnly() &&
            ( e.which === OO.ui.Keys.SPACE || e.which === OO.ui.Keys.ENTER )
        ) {
            this.activate();
            return false;
      Severity: Major
      Found in resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js and 1 other location - About 1 hr to fix
      resources/lib/ooui/oojs-ui-widgets.js on lines 4162..4196

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if ( config.mustBeAfter !== undefined ) {
            var mustBeAfter = moment( config.mustBeAfter, 'YYYY-MM-DD' );
            if ( mustBeAfter.isValid() ) {
                this.mustBeAfter = mustBeAfter;
            }
      Severity: Minor
      Found in resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js and 1 other location - About 30 mins to fix
      resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js on lines 151..156

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          mw.widgets.DateInputWidget.prototype.focus = function () {
        this.activate();
        return this;
    };
      Severity: Minor
      Found in resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js and 1 other location - About 30 mins to fix
      resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js on lines 369..372

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if ( config.mustBeBefore !== undefined ) {
            var mustBeBefore = moment( config.mustBeBefore, 'YYYY-MM-DD' );
            if ( mustBeBefore.isValid() ) {
                this.mustBeBefore = mustBeBefore;
            }
      Severity: Minor
      Found in resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js and 1 other location - About 30 mins to fix
      resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js on lines 145..150

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          mw.widgets.DateInputWidget.prototype.blur = function () {
        this.deactivate();
        return this;
    };
      Severity: Minor
      Found in resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js and 1 other location - About 30 mins to fix
      resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js on lines 361..364

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status