wikimedia/mediawiki-core

File mediawiki.loader.js has 928 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*!
 * Defines mw.loader, the infrastructure for loading ResourceLoader
 * modules.
 *
 * This file is appended directly to the code in startup/mediawiki.js

Function execute has 111 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function execute( module ) {
        if ( registry[ module ].state !== 'loaded' ) {
            throw new Error( 'Module in state "' + registry[ module ].state + '" may not execute: ' + module );
        }

Function batchRequest has 58 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function batchRequest( batch ) {
        if ( !batch.length ) {
            return;
        }

Function runScript has 51 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        var runScript = function () {
            $CODE.profileScriptStart();
            var script = registry[ module ].script;
            var markModuleReady = function () {
                $CODE.profileScriptEnd();

Function doPropagation has 49 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function doPropagation() {
        var didPropagate = true;
        var module;

        // Keep going until the last iteration performed no actions.

Function set has 47 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        set: function ( module ) {
            var descriptor = registry[ module ],
                key = getModuleKey( module );

            if (

Function work has 36 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        work: function () {
            store.init();

            var q = queue.length,
                storedImplementations = [],

Function enqueue has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function enqueue( dependencies, ready, error ) {
        if ( allReady( dependencies ) ) {
            // Run ready immediately
            if ( ready ) {
                ready();

Function sortDependencies has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function sortDependencies( module, resolved, unresolved ) {
        if ( !( module in registry ) ) {
            throw new Error( 'Unknown module: ' + module );
        }

Function impl has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

        impl: function ( declarator ) {
            var data = declarator(),
                module = data[ 0 ],
                script = data[ 1 ] || null,
                style = data[ 2 ] || null,

Consider simplifying this complex logical expression.

Open

            if (
                // Already stored a copy of this exact version
                key in this.items ||
                // Module failed to load
                !descriptor ||

Function registerOne has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    function registerOne( module, version, dependencies, group, source, skip ) {

Avoid deeply nested control flow statements.

Open

                        if ( baseModuleError && baseModules.indexOf( module ) === -1 ) {
                            // Propate error from base module to all regular (non-base) modules
                            registry[ module ].state = 'error';
                            didPropagate = true;
                        } else if ( registry[ module ].dependencies.indexOf( errorModule ) !== -1 ) {

Function implement has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

        implement: function ( module, script, style, messages, templates, deprecationWarning ) {

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if ( registry[ name ].state !== 'error' && registry[ name ].state !== 'missing' ) {
                setAndPropagate( name, 'loaded' );
            }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if ( registry[ name ].state !== 'error' && registry[ name ].state !== 'missing' ) {
                setAndPropagate( name, 'loaded' );
            }

• Read up
  Read up