Sign upLogin

wikimedia/mediawiki-extensions-CirrusSearch

View on GitHub
Star

Showing 718 of 718 total issues

File AnalysisConfigBuilder.php has 1462 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace CirrusSearch\Maintenance;

use CirrusSearch\CirrusSearch;
Severity: Major
Found in includes/Maintenance/AnalysisConfigBuilder.php - About 3 days to fix

    Method customize has 521 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function customize( $config, $language ) {
        $langName = $this->getDefaultTextAnalyzerType( $language );
        $icuEnabled = $this->shouldActivateIcuFolding( $language );

        // prep an AnalyzerBuilder for this language, with proper ICU folding setup.
    Severity: Major
    Found in includes/Maintenance/AnalysisConfigBuilder.php - About 2 days to fix

      File Searcher.php has 676 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace CirrusSearch;

use CirrusSearch\Fallbacks\FallbackRunner;
      Severity: Major
      Found in includes/Searcher.php - About 1 day to fix

        Method defaults has 291 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function defaults( $language ) {
        $defaults = [
            'analyzer' => [
                'text' => [
                    'type' => $this->getDefaultTextAnalyzerType( $language ),
        Severity: Major
        Found in includes/Maintenance/AnalysisConfigBuilder.php - About 1 day to fix

          Function customize has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
          Open

              private function customize( $config, $language ) {
        $langName = $this->getDefaultTextAnalyzerType( $language );
        $icuEnabled = $this->shouldActivateIcuFolding( $language );

        // prep an AnalyzerBuilder for this language, with proper ICU folding setup.
          Severity: Minor
          Found in includes/Maintenance/AnalysisConfigBuilder.php - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          SearchContext has 63 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class SearchContext implements WarningCollector, FilterBuilder {
    /**
     * @var SearchConfig
     */
    private $config;
          Severity: Major
          Found in includes/Search/SearchContext.php - About 1 day to fix

            File UpdateSuggesterIndex.php has 522 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php

namespace CirrusSearch\Maintenance;

use CirrusSearch\BuildDocument\Completion\SuggestBuilder;
            Severity: Major
            Found in maintenance/UpdateSuggesterIndex.php - About 1 day to fix

              File ForceSearchIndex.php has 516 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php

namespace CirrusSearch\Maintenance;

use BatchRowIterator;
              Severity: Major
              Found in maintenance/ForceSearchIndex.php - About 1 day to fix

                File DataSender.php has 507 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php

namespace CirrusSearch;

use CirrusSearch\BuildDocument\BuildDocument;
                Severity: Major
                Found in includes/DataSender.php - About 1 day to fix

                  File QueryStringRegexParser.php has 507 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php

namespace CirrusSearch\Parser\QueryStringRegex;

use CirrusSearch\Parser\AST\BooleanClause;
                  Severity: Major
                  Found in includes/Parser/QueryStringRegex/QueryStringRegexParser.php - About 1 day to fix

                    Function siteMatrixLoader has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function siteMatrixLoader() {
        return function () {
            global $wgConf;

            $matrix = new SiteMatrix;
                    Severity: Minor
                    Found in includes/SiteMatrixInterwikiResolver.php - About 1 day to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getProfile has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getProfile( $name ) {
        $settings = $this->wrapped->getProfile( $name );
        if ( $settings === null ) {
            return null;
        }
                    Severity: Minor
                    Found in includes/Profile/PhraseSuggesterProfileRepoWrapper.php - About 6 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    File SearchContext.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php

namespace CirrusSearch\Search;

use CirrusSearch\CirrusDebugOptions;
                    Severity: Minor
                    Found in includes/Search/SearchContext.php - About 6 hrs to fix

                      File Hooks.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php

namespace CirrusSearch;

use CirrusSearch\Search\FancyTitleResultsType;
                      Severity: Minor
                      Found in includes/Hooks.php - About 6 hrs to fix

                        Function expression has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private function expression() {
        $clauses = [];
        $left = null;
        // Last boolean operator seen, -1 means none
        $lastBoolType = -1;
                        Severity: Minor
                        Found in includes/Parser/QueryStringRegex/QueryStringRegexParser.php - About 5 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method defaults has 146 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            protected function defaults( $language ) {
        // Use default lowercase filter
        $lowercase_type = [ 'type' => 'lowercase' ];
        if ( $this->isIcuAvailable() ) {
            $lowercase_type = [
                        Severity: Major
                        Found in includes/Maintenance/SuggesterAnalysisConfigBuilder.php - About 5 hrs to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function __construct( SearchConfig $config, $weight, $profile ) {
        parent::__construct( $config, $weight );
        if ( isset( $profile['impact'] ) ) {
            $this->impact = $this->getOverriddenFactor( $profile['impact'] );
            if ( $this->impact <= 0 ) {
                          Severity: Major
                          Found in includes/Search/Rescore/LogMultFunctionScoreBuilder.php and 1 other location - About 5 hrs to fix
                          includes/Search/Rescore/SatuFunctionScoreBuilder.php on lines 30..55

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 196.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                              public function __construct( SearchConfig $config, $weight, $profile ) {
        parent::__construct( $config, $weight );
        if ( isset( $profile['k'] ) ) {
            $this->k = $this->getOverriddenFactor( $profile['k'] );
            if ( $this->k <= 0 ) {
                          Severity: Major
                          Found in includes/Search/Rescore/SatuFunctionScoreBuilder.php and 1 other location - About 5 hrs to fix
                          includes/Search/Rescore/LogMultFunctionScoreBuilder.php on lines 26..51

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 196.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          File UpdateOneSearchIndexConfig.php has 400 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          <?php

namespace CirrusSearch\Maintenance;

use CirrusSearch\Connection;
                          Severity: Minor
                          Found in maintenance/UpdateOneSearchIndexConfig.php - About 5 hrs to fix

                            Method doJob has 137 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                protected function doJob() {
        $profile = $this->searchConfig
            ->getProfileService()
            ->loadProfileByName( SearchProfileService::SANEITIZER, $this->params['profile'], false );
                            Severity: Major
                            Found in includes/Job/CheckerJob.php - About 5 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language