Showing 730 of 730 total issues
File AnalysisConfigBuilder.php
has 1321 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CirrusSearch\Maintenance;
use CirrusSearch\CirrusSearch;
Method customize
has 438 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function customize( $config, $language ) {
$langName = $this->getDefaultTextAnalyzerType( $language );
switch ( $langName ) {
// Please add languages in alphabetical order.
File Searcher.php
has 671 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CirrusSearch;
use CirrusSearch\Fallbacks\FallbackRunner;
Method defaults
has 291 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function defaults( $language ) {
$defaults = [
'analyzer' => [
'text' => [
'type' => $this->getDefaultTextAnalyzerType( $language ),
Function customize
has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring. Open
private function customize( $config, $language ) {
$langName = $this->getDefaultTextAnalyzerType( $language );
switch ( $langName ) {
// Please add languages in alphabetical order.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
SearchContext
has 63 functions (exceeds 20 allowed). Consider refactoring. Open
class SearchContext implements WarningCollector, FilterBuilder {
/**
* @var SearchConfig
*/
private $config;
File ForceSearchIndex.php
has 516 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CirrusSearch\Maintenance;
use BatchRowIterator;
File DataSender.php
has 511 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CirrusSearch;
use CirrusSearch\BuildDocument\BuildDocument;
File QueryStringRegexParser.php
has 507 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CirrusSearch\Parser\QueryStringRegex;
use CirrusSearch\Parser\AST\BooleanClause;
File UpdateSuggesterIndex.php
has 504 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CirrusSearch\Maintenance;
use CirrusSearch\BuildDocument\Completion\SuggestBuilder;
Function siteMatrixLoader
has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring. Open
private function siteMatrixLoader() {
return function () {
global $wgConf;
$matrix = new SiteMatrix;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function sendUpdateWeightedTags
has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring. Open
public function sendUpdateWeightedTags(
string $indexSuffix,
array $docIds,
string $tagField,
string $tagPrefix,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getProfile
has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring. Open
public function getProfile( $name ) {
$settings = $this->wrapped->getProfile( $name );
if ( $settings === null ) {
return null;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File Hooks.php
has 421 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CirrusSearch;
use ApiBase;
File SearchContext.php
has 420 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CirrusSearch\Search;
use CirrusSearch\CirrusDebugOptions;
Function expression
has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring. Open
private function expression() {
$clauses = [];
$left = null;
// Last boolean operator seen, -1 means none
$lastBoolType = -1;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method defaults
has 146 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function defaults( $language ) {
// Use default lowercase filter
$lowercase_type = [ 'type' => 'lowercase' ];
if ( $this->isIcuAvailable() ) {
$lowercase_type = [
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function __construct( SearchConfig $config, $weight, $profile ) {
parent::__construct( $config, $weight );
if ( isset( $profile['k'] ) ) {
$this->k = $this->getOverriddenFactor( $profile['k'] );
if ( $this->k <= 0 ) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 196.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function __construct( SearchConfig $config, $weight, $profile ) {
parent::__construct( $config, $weight );
if ( isset( $profile['impact'] ) ) {
$this->impact = $this->getOverriddenFactor( $profile['impact'] );
if ( $this->impact <= 0 ) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 196.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method doJob
has 136 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function doJob() {
$profile = $this->searchConfig
->getProfileService()
->loadProfileByName( SearchProfileService::SANEITIZER, $this->params['profile'], false );