Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star
adyen_gateway/BlankAddressFields.php

Summary

Maintainability
A
1 hr
Test Coverage

Function stage has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function stage( GatewayType $adapter, $normalized, &$stagedData ) {
        // If any address field is not blank, fill in blanks with 'NA'
        // if all fields are blank, leave it alone
        foreach ( self::$addressFields as $address ) {
            if ( !empty( $normalized[ $address ] ) ) {
Severity: Minor
Found in adyen_gateway/BlankAddressFields.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status