Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star
adyen_gateway/EncryptedCardParameters.php

Summary

Maintainability
A
45 mins
Test Coverage

Function validate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate( GatewayType $adapter, $normalized, &$errors ) {
        // validate() is called at various points in the process. We only want to require these
        // parameters for card payments, and only during the 'donate' action (not during initial
        // form load nor during recurring upgrade). It's a bit odd to find the action in the
        // $normalized array, but there it is!
Severity: Minor
Found in adyen_gateway/EncryptedCardParameters.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status