Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star
braintree_gateway/braintree.adapter.php

Summary

Maintainability
C
1 day
Test Coverage

Function getLocalizedValidationErrorResult has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
        $localizedErrors = [];
        foreach ( $validationErrors as $error ) {
            $field = $error->getField();
            $debugMessage = $error->getDebugMessage();
Severity: Minor
Found in braintree_gateway/braintree.adapter.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handleCreatedPayment has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function handleCreatedPayment(
        CreatePaymentResponse $createPaymentResult, PaymentProvider $provider
    ): PaymentResult {
        $transactionStatus = $createPaymentResult->getStatus();
Severity: Minor
Found in braintree_gateway/braintree.adapter.php - About 1 hr to fix

    Method getLocalizedValidationErrorResult has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
        $localizedErrors = [];
        foreach ( $validationErrors as $error ) {
            $field = $error->getField();
            $debugMessage = $error->getDebugMessage();
    Severity: Minor
    Found in braintree_gateway/braintree.adapter.php - About 1 hr to fix

      Method defineTransactions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function defineTransactions() {
        $this->transactions = [
            TransactionType::AUTHORIZE => [
                'request' => [
                    'amount',
      Severity: Minor
      Found in braintree_gateway/braintree.adapter.php - About 1 hr to fix

        Method doPayment has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function doPayment() {
        $this->ensureUniqueOrderID();
        $this->session_addDonorData();
        $this->setCurrentTransaction( TransactionType::AUTHORIZE );
        Gateway_Extras_CustomFilters::onGatewayReady( $this );
        Severity: Minor
        Found in braintree_gateway/braintree.adapter.php - About 1 hr to fix

          Function handleCreatedPayment has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function handleCreatedPayment(
        CreatePaymentResponse $createPaymentResult, PaymentProvider $provider
    ): PaymentResult {
        $transactionStatus = $createPaymentResult->getStatus();
          Severity: Minor
          Found in braintree_gateway/braintree.adapter.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status