Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star
gateway_common/DonationApiBase.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method serializeErrors has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function serializeErrors( $errors ) {
        $serializedErrors = [];
        foreach ( $errors as $error ) {
            if ( $error instanceof ValidationError ) {
                $country = $this->adapter->getData_Unstaged_Escaped( 'country' );
Severity: Minor
Found in gateway_common/DonationApiBase.php - About 1 hr to fix

    Function serializeErrors has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function serializeErrors( $errors ) {
        $serializedErrors = [];
        foreach ( $errors as $error ) {
            if ( $error instanceof ValidationError ) {
                $country = $this->adapter->getData_Unstaged_Escaped( 'country' );
    Severity: Minor
    Found in gateway_common/DonationApiBase.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method setAdapterAndValidate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function setAdapterAndValidate() {
        $this->ensureState();

        DonationInterface::setSmashPigProvider( $this->gateway );
    Severity: Minor
    Found in gateway_common/DonationApiBase.php - About 1 hr to fix

      Function setAdapterAndValidate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function setAdapterAndValidate() {
        $this->ensureState();

        DonationInterface::setSmashPigProvider( $this->gateway );
      Severity: Minor
      Found in gateway_common/DonationApiBase.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function ensureState has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function ensureState() {
        if ( !$this->donationData ) {
            $this->donationData = $this->extractRequestParams();
        }
      Severity: Minor
      Found in gateway_common/DonationApiBase.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status