Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star
gateway_common/ResultSwitcher.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method handleResultRequest has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function handleResultRequest() {
        // no longer letting people in without these things. If this is
        // preventing you from doing something, you almost certainly want to be
        // somewhere else.
        $deadSession = false;
Severity: Major
Found in gateway_common/ResultSwitcher.php - About 2 hrs to fix

    Function handleResultRequest has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function handleResultRequest() {
        // no longer letting people in without these things. If this is
        // preventing you from doing something, you almost certainly want to be
        // somewhere else.
        $deadSession = false;
    Severity: Minor
    Found in gateway_common/ResultSwitcher.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status