Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star
gateway_common/employerSearch.api.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method getEmployersList has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function getEmployersList() {
        $employersListDataFile = $this->getConfig()->get( 'DonationInterfaceEmployersListDataFileLocation' );
        // Check the employer data file exists
        if ( !file_exists( $employersListDataFile ) ) {
            $this->setError( 'Employer data file doesn\'t exist: ' . $employersListDataFile );
Severity: Minor
Found in gateway_common/employerSearch.api.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return $employerList;
    Severity: Major
    Found in gateway_common/employerSearch.api.php - About 30 mins to fix

      Function getEmployersList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getEmployersList() {
        $employersListDataFile = $this->getConfig()->get( 'DonationInterfaceEmployersListDataFileLocation' );
        // Check the employer data file exists
        if ( !file_exists( $employersListDataFile ) ) {
            $this->setError( 'Employer data file doesn\'t exist: ' . $employersListDataFile );
      Severity: Minor
      Found in gateway_common/employerSearch.api.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status