Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star
gravy_gateway/gravy.adapter.php

Summary

Maintainability
F
3 days
Test Coverage

File gravy.adapter.php has 323 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

use MediaWiki\MediaWikiServices;
use Psr\Log\LogLevel;
use SmashPig\Core\PaymentError;
Severity: Minor
Found in gravy_gateway/gravy.adapter.php - About 3 hrs to fix

    GravyAdapter has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class GravyAdapter extends GatewayAdapter implements RecurringConversion {
    use RecurringConversionTrait;

    /**
     * @var string
    Severity: Minor
    Found in gravy_gateway/gravy.adapter.php - About 2 hrs to fix

      Method getLocalizedValidationErrorResult has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
        $localizedErrors = [];
        foreach ( $validationErrors as $error ) {
            $field = $error->getField();
            $debugMessage = $error->getDebugMessage();
      Severity: Minor
      Found in gravy_gateway/gravy.adapter.php - About 2 hrs to fix

        Function handleCreatedPayment has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function handleCreatedPayment(
        IPaymentProvider $provider, PaymentDetailResponse $authorizeResult
    ): PaymentResult {
        $transactionStatus = $authorizeResult->getStatus();
        Severity: Minor
        Found in gravy_gateway/gravy.adapter.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getLocalizedValidationErrorResult has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
        $localizedErrors = [];
        foreach ( $validationErrors as $error ) {
            $field = $error->getField();
            $debugMessage = $error->getDebugMessage();
        Severity: Minor
        Found in gravy_gateway/gravy.adapter.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method handleCreatedPayment has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function handleCreatedPayment(
        IPaymentProvider $provider, PaymentDetailResponse $authorizeResult
    ): PaymentResult {
        $transactionStatus = $authorizeResult->getStatus();
        Severity: Minor
        Found in gravy_gateway/gravy.adapter.php - About 1 hr to fix

          Function updateResponseData has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function updateResponseData( PaymentDetailResponse $authorizeResult ) {
        $responseData = [];

        // Add the gravy-generated transaction ID to the DonationData object
        // to be sent to the queues
          Severity: Minor
          Found in gravy_gateway/gravy.adapter.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method defineTransactions has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function defineTransactions() {
        $this->transactions = [
            'authorize' => [
                'request' => [
                    'city',
          Severity: Minor
          Found in gravy_gateway/gravy.adapter.php - About 1 hr to fix

            Method doPayment has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function doPayment() {
        $this->ensureUniqueOrderID();
        $this->session_addDonorData();
        $this->runDoPaymentFilters();
        if ( !$this->filterActionIsProcess() ) {
            Severity: Minor
            Found in gravy_gateway/gravy.adapter.php - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  protected function getLocalizedValidationErrorResult( array $validationErrors ): PaymentResult {
        $localizedErrors = [];
        foreach ( $validationErrors as $error ) {
            $field = $error->getField();
            $debugMessage = $error->getDebugMessage();
              Severity: Major
              Found in gravy_gateway/gravy.adapter.php and 1 other location - About 1 day to fix
              dlocal_gateway/dlocal.adapter.php on lines 265..317

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 311.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          'authorize' => [
                'request' => [
                    'city',
                    'country',
                    'currency',
              Severity: Minor
              Found in gravy_gateway/gravy.adapter.php and 1 other location - About 55 mins to fix
              dlocal_gateway/dlocal.adapter.php on lines 137..166

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 99.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status