Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star
includes/RecurUpgrade/Validator.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function validate has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function validate( array $params, bool $posted ): bool {
        if (
            empty( $params['checksum'] ) ||
            empty( $params['contact_id'] ) ||
            !is_numeric( $params['contact_id'] )
Severity: Minor
Found in includes/RecurUpgrade/Validator.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateAmount has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    protected function validateAmount( array $params, bool $posted ): bool {
        if ( !$posted || ( isset( $params['submit'] ) && $params['submit'] === 'cancel' ) ) {
            // Not doing anything with the parameters unless we're posted, so don't worry about them
            return true;
        }
Severity: Minor
Found in includes/RecurUpgrade/Validator.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in includes/RecurUpgrade/Validator.php - About 30 mins to fix

    Function validateToken has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function validateToken( array $params, $posted ) {
        if ( empty( $params['token'] ) ) {
            if ( $posted ) {
                return false;
            }
    Severity: Minor
    Found in includes/RecurUpgrade/Validator.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status