Sign upLogin

wikimedia/mediawiki-extensions-DonationInterface

View on GitHub
Star
ingenico_gateway/ingenico.adapter.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function processDonorReturn has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function processDonorReturn( $requestValues ) {
        // FIXME: make sure we're processing the order ID we expect!
        /** @var HostedCheckoutProvider $provider */
        $provider = $this->getPaymentProvider();
        '@phan-var HostedCheckoutProvider $provider';
Severity: Minor
Found in ingenico_gateway/ingenico.adapter.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method processDonorReturn has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function processDonorReturn( $requestValues ) {
        // FIXME: make sure we're processing the order ID we expect!
        /** @var HostedCheckoutProvider $provider */
        $provider = $this->getPaymentProvider();
        '@phan-var HostedCheckoutProvider $provider';
Severity: Major
Found in ingenico_gateway/ingenico.adapter.php - About 2 hrs to fix

    Method defineTransactions has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function defineTransactions() {
        $this->transactions['createPaymentSession'] = [
            'request' => [
                'use_3d_secure',
                'amount',
    Severity: Minor
    Found in ingenico_gateway/ingenico.adapter.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status