wikimedia/mediawiki-extensions-Flow

View on GitHub

Showing 681 of 907 total issues

File handlebars-v3.0.0.js has 2851 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!

 handlebars v3.0.0

Copyright (C) 2011-2014 by Yehuda Katz
Severity: Major
Found in modules/libs/handlebars-v3.0.0.js - About 1 wk to fix

    Function __module14__ has 736 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var __module14__ = (function(__dependency1__, __dependency2__, __dependency3__, __dependency4__) {
      "use strict";
      var __exports__;
      var COMPILER_REVISION = __dependency1__.COMPILER_REVISION;
      var REVISION_CHANGES = __dependency1__.REVISION_CHANGES;
    Severity: Major
    Found in modules/libs/handlebars-v3.0.0.js - About 3 days to fix

      File Hooks.php has 1351 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      // phpcs:disable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName
      
      namespace Flow;
      Severity: Major
      Found in includes/Hooks.php - About 3 days to fix

        Function __module9__ has 531 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        var __module9__ = (function() {
          "use strict";
          var __exports__;
          /* jshint ignore:start */
          /* istanbul ignore next */
        Severity: Major
        Found in modules/libs/handlebars-v3.0.0.js - About 2 days to fix

          Function handlebars has 527 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            var handlebars = (function(){
            var parser = {trace: function trace() { },
            yy: {},
            symbols_: {"error":2,"root":3,"program":4,"EOF":5,"program_repetition0":6,"statement":7,"mustache":8,"block":9,"rawBlock":10,"partial":11,"content":12,"COMMENT":13,"CONTENT":14,"openRawBlock":15,"END_RAW_BLOCK":16,"OPEN_RAW_BLOCK":17,"helperName":18,"openRawBlock_repetition0":19,"openRawBlock_option0":20,"CLOSE_RAW_BLOCK":21,"openBlock":22,"block_option0":23,"closeBlock":24,"openInverse":25,"block_option1":26,"OPEN_BLOCK":27,"openBlock_repetition0":28,"openBlock_option0":29,"openBlock_option1":30,"CLOSE":31,"OPEN_INVERSE":32,"openInverse_repetition0":33,"openInverse_option0":34,"openInverse_option1":35,"openInverseChain":36,"OPEN_INVERSE_CHAIN":37,"openInverseChain_repetition0":38,"openInverseChain_option0":39,"openInverseChain_option1":40,"inverseAndProgram":41,"INVERSE":42,"inverseChain":43,"inverseChain_option0":44,"OPEN_ENDBLOCK":45,"OPEN":46,"mustache_repetition0":47,"mustache_option0":48,"OPEN_UNESCAPED":49,"mustache_repetition1":50,"mustache_option1":51,"CLOSE_UNESCAPED":52,"OPEN_PARTIAL":53,"partialName":54,"partial_repetition0":55,"partial_option0":56,"param":57,"sexpr":58,"OPEN_SEXPR":59,"sexpr_repetition0":60,"sexpr_option0":61,"CLOSE_SEXPR":62,"hash":63,"hash_repetition_plus0":64,"hashSegment":65,"ID":66,"EQUALS":67,"blockParams":68,"OPEN_BLOCK_PARAMS":69,"blockParams_repetition_plus0":70,"CLOSE_BLOCK_PARAMS":71,"path":72,"dataName":73,"STRING":74,"NUMBER":75,"BOOLEAN":76,"DATA":77,"pathSegments":78,"SEP":79,"$accept":0,"$end":1},
            terminals_: {2:"error",5:"EOF",13:"COMMENT",14:"CONTENT",16:"END_RAW_BLOCK",17:"OPEN_RAW_BLOCK",21:"CLOSE_RAW_BLOCK",27:"OPEN_BLOCK",31:"CLOSE",32:"OPEN_INVERSE",37:"OPEN_INVERSE_CHAIN",42:"INVERSE",45:"OPEN_ENDBLOCK",46:"OPEN",49:"OPEN_UNESCAPED",52:"CLOSE_UNESCAPED",53:"OPEN_PARTIAL",59:"OPEN_SEXPR",62:"CLOSE_SEXPR",66:"ID",67:"EQUALS",69:"OPEN_BLOCK_PARAMS",71:"CLOSE_BLOCK_PARAMS",74:"STRING",75:"NUMBER",76:"BOOLEAN",77:"DATA",79:"SEP"},
          Severity: Major
          Found in modules/libs/handlebars-v3.0.0.js - About 2 days to fix

            File container.php has 954 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            use Flow\Data\Index\PostRevisionBoardHistoryIndex;
            use Flow\Data\Index\PostRevisionTopicHistoryIndex;
            use Flow\Data\Index\PostSummaryRevisionBoardHistoryIndex;
            Severity: Major
            Found in container.php - About 2 days to fix

              File FlowActions.php has 824 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php
              
              use Flow\Data\Listener\RecentChangesListener;
              use Flow\Log\ModerationLogger;
              use Flow\Model\AbstractRevision;
              Severity: Major
              Found in FlowActions.php - About 1 day to fix

                Function __module13__ has 382 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                var __module13__ = (function(__dependency1__, __dependency2__, __dependency3__) {
                  "use strict";
                  var __exports__ = {};
                  var Exception = __dependency1__;
                  var isArray = __dependency2__.isArray;
                Severity: Major
                Found in modules/libs/handlebars-v3.0.0.js - About 1 day to fix

                  File RevisionFormatter.php has 795 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  
                  namespace Flow\Formatter;
                  
                  use ApiResult;
                  Severity: Major
                  Found in includes/Formatter/RevisionFormatter.php - About 1 day to fix

                    File TopicBlock.php has 738 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    
                    namespace Flow\Block;
                    
                    use Flow\Container;
                    Severity: Major
                    Found in includes/Block/TopicBlock.php - About 1 day to fix

                      File mw.flow.Initializer.js has 679 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /* eslint-disable no-jquery/no-global-selector */
                      ( function () {
                          /**
                           * Initializer object for flow-initialize
                           *
                      Severity: Major
                      Found in modules/mw.flow.Initializer.js - About 1 day to fix

                        Hooks has 78 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        class Hooks implements
                            ResourceLoaderRegisterModulesHook,
                            BeforePageDisplayHook,
                            GetPreferencesHook,
                            OldChangesListRecentChangesLineHook,
                        Severity: Major
                        Found in includes/Hooks.php - About 1 day to fix

                          Function lexer has 276 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            var lexer = (function(){
                            var lexer = ({EOF:1,
                            parseError:function parseError(str, hash) {
                                    if (this.yy.parser) {
                                        this.yy.parser.parseError(str, hash);
                          Severity: Major
                          Found in modules/libs/handlebars-v3.0.0.js - About 1 day to fix

                            File Controller.php has 612 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            <?php
                            
                            namespace Flow\Notifications;
                            
                            use EchoEvent;
                            Severity: Major
                            Found in includes/Notifications/Controller.php - About 1 day to fix

                              Function buildActions has a Cognitive Complexity of 65 (exceeds 5 allowed). Consider refactoring.
                              Open

                                  public function buildActions( FormatterRow $row ) {
                                      global $wgThanksSendToBots;
                              
                                      $user = $this->permissions->getUser();
                                      $workflow = $row->workflow;
                              Severity: Minor
                              Found in includes/Formatter/RevisionFormatter.php - About 1 day to fix

                              Cognitive Complexity

                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                              A method's cognitive complexity is based on a few simple rules:

                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                              • Code is considered more complex for each "break in the linear flow of the code"
                              • Code is considered more complex when "flow breaking structures are nested"

                              Further reading

                              AbstractRevision has 62 functions (exceeds 20 allowed). Consider refactoring.
                              Open

                              abstract class AbstractRevision {
                                  public const MODERATED_NONE = '';
                                  public const MODERATED_HIDDEN = 'hide';
                                  public const MODERATED_DELETED = 'delete';
                                  public const MODERATED_SUPPRESSED = 'suppress';
                              Severity: Major
                              Found in includes/Model/AbstractRevision.php - About 1 day to fix

                                File UrlGenerator.php has 518 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                <?php
                                
                                namespace Flow;
                                
                                use Flow\Collection\PostCollection;
                                Severity: Major
                                Found in includes/UrlGenerator.php - About 1 day to fix

                                  Function __module2__ has 197 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                  var __module2__ = (function(__dependency1__, __dependency2__) {
                                    "use strict";
                                    var __exports__ = {};
                                    var Utils = __dependency1__;
                                    var Exception = __dependency2__;
                                  Severity: Major
                                  Found in modules/libs/handlebars-v3.0.0.js - About 7 hrs to fix

                                    File AbstractRevision.php has 491 lines of code (exceeds 250 allowed). Consider refactoring.
                                    Open

                                    <?php
                                    
                                    namespace Flow\Model;
                                    
                                    use Flow\Collection\AbstractCollection;
                                    Severity: Minor
                                    Found in includes/Model/AbstractRevision.php - About 7 hrs to fix

                                      Function __module6__ has 184 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                      var __module6__ = (function(__dependency1__, __dependency2__, __dependency3__) {
                                        "use strict";
                                        var __exports__ = {};
                                        var Utils = __dependency1__;
                                        var Exception = __dependency2__;
                                      Severity: Major
                                      Found in modules/libs/handlebars-v3.0.0.js - About 7 hrs to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language