wikimedia/mediawiki-extensions-Flow

View on GitHub

Showing 907 of 907 total issues

Function updateTopicList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private function updateTopicList( $workflow, $wiki ) {
        $id = '';
        $batchSize = $this->getBatchSize();
        $count = $batchSize;
        $dbr = Container::get( 'db.factory' )->getDB( DB_REPLICA );
Severity: Minor
Found in maintenance/FlowUpdateUserWiki.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        global $wgLang;

        $provided = $this->getArg( 0 );
        $namespace = $wgLang->getNsIndex( $provided );
Severity: Minor
Found in maintenance/convertNamespaceFromWikitext.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processHeaders has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function processHeaders( $recorder ) {
        $storage = Container::get( 'storage.header' );
        $batchSize = $this->getBatchSize();
        $count = $batchSize;
        $id = '';
Severity: Minor
Found in maintenance/FlowPopulateLinksTables.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateRevision has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function updateRevision( $columnPrefix, IDatabase $dbw, $continue = null ) {
        $rows = $dbw->newSelectQueryBuilder()
            ->select( [ 'rev_id', 'rev_type' ] )
            ->from( 'flow_revision' )
            ->where( [
Severity: Minor
Found in maintenance/FlowFixUserIp.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function execute() {
        $dir = __DIR__ . '/../handlebars';
        $this->lightncandy = new TemplateHelper( $dir, /* $forceRecompile = */ true );

        // looking for 664 permissions on the final files
Severity: Minor
Found in maintenance/compileLightncandy.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateTreeRevision has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function updateTreeRevision( IDatabase $dbw, $continue = null ) {
        $rows = $dbw->newSelectQueryBuilder()
            ->select( [ 'tree_rev_id' ] )
            ->from( 'flow_tree_revision' )
            ->where( [
Severity: Minor
Found in maintenance/FlowFixUserIp.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateHeader has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private function updateHeader( $workflow, $wiki ) {
        $id = '';
        $batchSize = $this->getBatchSize();
        $count = $batchSize;
        $dbr = Container::get( 'db.factory' )->getDB( DB_REPLICA );
Severity: Minor
Found in maintenance/FlowUpdateUserWiki.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language